Bug 226543

Summary: Port media code to the HTML event loop
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, calvaris, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, graouts, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, mmaxfield, peng.liu6, philipj, rniwa, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-06-02 10:14:55 PDT
Port MainThreadGenericEventQueue to the HTML event loop.
Attachments
WIP Patch (5.01 KB, patch)
2021-06-02 10:16 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (14.64 KB, patch)
2021-06-02 12:22 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP Patch (18.05 KB, patch)
2021-06-02 12:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (26.45 KB, patch)
2021-06-02 14:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (37.07 KB, patch)
2021-06-02 17:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-02 10:16:23 PDT
Created attachment 430372 [details] WIP Patch
Chris Dumez
Comment 2 2021-06-02 12:22:07 PDT
Created attachment 430388 [details] WIP Patch
Chris Dumez
Comment 3 2021-06-02 12:51:47 PDT
Created attachment 430393 [details] WIP Patch
Chris Dumez
Comment 4 2021-06-02 14:44:12 PDT
Created attachment 430410 [details] Patch
Ryosuke Niwa
Comment 5 2021-06-02 16:51:52 PDT
Comment on attachment 430410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430410&action=review > Source/WebCore/platform/DeferrableTask.h:109 > + scriptExecutionContext()->eventLoop().queueTask(TaskSource::MediaElement, [weakThis = makeWeakPtr(*this), task = WTFMove(task)] { Not in this patch but we should add the capability to cancel a task we scheduled in the event loop.
Peng Liu
Comment 6 2021-06-02 17:01:07 PDT
Comment on attachment 430410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430410&action=review > Source/WebCore/platform/DeferrableTask.h:57 > + bool m_hasPendingTask { false }; Nit. `m_isPending` seems better?
Chris Dumez
Comment 7 2021-06-02 17:38:43 PDT
Created attachment 430425 [details] Patch
EWS
Comment 8 2021-06-02 18:54:43 PDT
Committed r278392 (238417@main): <https://commits.webkit.org/238417@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430425 [details].
Radar WebKit Bug Importer
Comment 9 2021-06-02 18:55:18 PDT
<rdar://problem/78793607>
Note You need to log in before you can comment on or make changes to this bug.