| Summary: | Port media code to the HTML event loop | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | Media | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, calvaris, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, graouts, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, mmaxfield, peng.liu6, philipj, rniwa, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2021-06-02 10:14:55 PDT
Created attachment 430372 [details]
WIP Patch
Created attachment 430388 [details]
WIP Patch
Created attachment 430393 [details]
WIP Patch
Created attachment 430410 [details]
Patch
Comment on attachment 430410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430410&action=review > Source/WebCore/platform/DeferrableTask.h:109 > + scriptExecutionContext()->eventLoop().queueTask(TaskSource::MediaElement, [weakThis = makeWeakPtr(*this), task = WTFMove(task)] { Not in this patch but we should add the capability to cancel a task we scheduled in the event loop. Comment on attachment 430410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430410&action=review > Source/WebCore/platform/DeferrableTask.h:57 > + bool m_hasPendingTask { false }; Nit. `m_isPending` seems better? Created attachment 430425 [details]
Patch
Committed r278392 (238417@main): <https://commits.webkit.org/238417@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430425 [details]. |