Bug 226541

Summary: All CodeBlocks should be asynchronously sweepable.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: NEW    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
LastPatch none

Keith Miller
Reported 2021-06-02 09:54:43 PDT
All CodeBlocks should be asynchronously sweepable.
Attachments
WIP (26.11 KB, patch)
2021-06-02 09:55 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
LastPatch (35.23 KB, patch)
2021-06-05 18:38 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2021-06-02 09:55:02 PDT
Created attachment 430370 [details] WIP
Radar WebKit Bug Importer
Comment 2 2021-06-02 14:06:35 PDT
<rdar://problem/78782125>
Keith Miller
Comment 3 2021-06-05 18:38:40 PDT
Created attachment 430668 [details] LastPatch
Keith Miller
Comment 4 2021-06-05 18:39:44 PDT
Seems to be a 1-2% Speedo regression. I couldn't figure out where the regression came from. It doesn't seem to come from iterating the codeblock set with Subspace::forEachLiveObject instead of the CodeBlockSet. We also don't spend more than .3% of our time in CodeBlock destructors so it's not that the code blocks themselves got slower. My assumption is that the regression came from lost cache locality when destroying the code blocks. I'm gonna give up on this for now since I can't identify the reasoning for the slowdown.
Note You need to log in before you can comment on or make changes to this bug.