| Summary: | All CodeBlocks should be asynchronously sweepable. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Keith Miller
2021-06-02 09:54:43 PDT
Created attachment 430370 [details]
WIP
Created attachment 430668 [details]
LastPatch
Seems to be a 1-2% Speedo regression. I couldn't figure out where the regression came from. It doesn't seem to come from iterating the codeblock set with Subspace::forEachLiveObject instead of the CodeBlockSet. We also don't spend more than .3% of our time in CodeBlock destructors so it's not that the code blocks themselves got slower. My assumption is that the regression came from lost cache locality when destroying the code blocks. I'm gonna give up on this for now since I can't identify the reasoning for the slowdown. |