Bug 226511

Summary: Add log when creating NSURLSession that will not accept cookies
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-06-01 13:24:43 PDT
Add log when creating NSURLSession that will not accept cookies
Attachments
Patch (2.12 KB, patch)
2021-06-01 13:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2021-06-01 13:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.16 KB, patch)
2021-06-01 15:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2021-06-21 11:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-06-01 13:25:04 PDT
Created attachment 430285 [details] Patch
Alex Christensen
Comment 2 2021-06-01 13:25:07 PDT
<rdar://problem/77637158>
Chris Dumez
Comment 3 2021-06-01 13:26:41 PDT
Comment on attachment 430285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430285&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310 > + RELEASE_LOG_INFO(NetworkSession, "Creating network session that will not accept cookies."); Why RELEASE_LOG_INFO() and not a simple RELEASE_LOG()? Also, shouldn't this print the sessionID (or some kind of ID so we can identify the session)?
Alex Christensen
Comment 4 2021-06-01 13:32:25 PDT
Created attachment 430288 [details] Patch
Chris Dumez
Comment 5 2021-06-01 14:36:27 PDT
Comment on attachment 430288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430288&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310 > + RELEASE_LOG(NetworkSession, "Creating network session with ID %llu that will not accept cookies.", m_sessionID.toUInt64()); We should probably use PRIu64 even if this is a cocoa file.
Alex Christensen
Comment 6 2021-06-01 15:54:47 PDT
Created attachment 430301 [details] Patch
youenn fablet
Comment 7 2021-06-02 07:12:35 PDT
Comment on attachment 430301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430301&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310 > + RELEASE_LOG(NetworkSession, "Creating network session with ID %" PRIu64 " that will not accept cookies.", m_sessionID.toUInt64()); RELEASE_LOG_IF?
Alex Christensen
Comment 8 2021-06-21 11:33:47 PDT
Created attachment 431885 [details] Patch
Alex Christensen
Comment 9 2021-06-21 11:44:24 PDT
http://trac.webkit.org/r279071
Note You need to log in before you can comment on or make changes to this bug.