| Summary: | Add log when creating NSURLSession that will not accept cookies | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2021-06-01 13:24:43 PDT
Created attachment 430285 [details]
Patch
Comment on attachment 430285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430285&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310 > + RELEASE_LOG_INFO(NetworkSession, "Creating network session that will not accept cookies."); Why RELEASE_LOG_INFO() and not a simple RELEASE_LOG()? Also, shouldn't this print the sessionID (or some kind of ID so we can identify the session)? Created attachment 430288 [details]
Patch
Comment on attachment 430288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430288&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310 > + RELEASE_LOG(NetworkSession, "Creating network session with ID %llu that will not accept cookies.", m_sessionID.toUInt64()); We should probably use PRIu64 even if this is a cocoa file. Created attachment 430301 [details]
Patch
Comment on attachment 430301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430301&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310 > + RELEASE_LOG(NetworkSession, "Creating network session with ID %" PRIu64 " that will not accept cookies.", m_sessionID.toUInt64()); RELEASE_LOG_IF? Created attachment 431885 [details]
Patch
|