Bug 226499

Summary: Hit-testing does not account for clip-path set on parent of <iframe>
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Layout and RenderingAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227624
Bug Depends on: 226380, 227004    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Antoine Quint
Reported 2021-06-01 08:01:32 PDT
Hit-testing does not account for clip-path set on parent of <iframe>
Attachments
Patch (17.57 KB, patch)
2021-06-01 08:05 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (7.17 KB, patch)
2021-06-02 08:15 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-06-01 08:01:56 PDT
<rdar://77317612>
Antoine Quint
Comment 2 2021-06-01 08:05:20 PDT
Created attachment 430263 [details] Patch
Darin Adler
Comment 3 2021-06-01 14:32:58 PDT
Comment on attachment 430263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430263&action=review > LayoutTests/ChangeLog:15 > +2021-05-28 Antoine Quint <graouts@webkit.org> Double change log.
Antoine Quint
Comment 4 2021-06-02 08:15:29 PDT
Created attachment 430354 [details] Patch
Simon Fraser (smfr)
Comment 5 2021-06-02 14:56:26 PDT
Comment on attachment 430354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430354&action=review > Source/WebCore/rendering/RenderLayer.cpp:4114 > + if (renderer().hasClipPath() && !downcast<RenderBox>(renderer()).hitTestClipPath(hitTestLocation, toLayoutPoint(location() - renderBoxLocation()))) Are we sure that hitTestLocation is in the correct coordinate system for the call to hitTestClipPath()?
EWS
Comment 6 2021-06-02 15:00:46 PDT
Committed r278377 (238404@main): <https://commits.webkit.org/238404@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430354 [details].
Antoine Quint
Comment 7 2021-06-04 02:42:27 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 430354 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430354&action=review > > > Source/WebCore/rendering/RenderLayer.cpp:4114 > > + if (renderer().hasClipPath() && !downcast<RenderBox>(renderer()).hitTestClipPath(hitTestLocation, toLayoutPoint(location() - renderBoxLocation()))) > > Are we sure that hitTestLocation is in the correct coordinate system for the > call to hitTestClipPath()? I checked that this is the same we use when we hit test through RenderObject for the layer's outermost element.
Antoine Quint
Comment 8 2021-07-02 08:17:48 PDT
This caused bug 227624.
Antoine Quint
Comment 9 2021-07-02 08:19:28 PDT
(In reply to Antoine Quint from comment #7) > (In reply to Simon Fraser (smfr) from comment #5) > > Comment on attachment 430354 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=430354&action=review > > > > > Source/WebCore/rendering/RenderLayer.cpp:4114 > > > + if (renderer().hasClipPath() && !downcast<RenderBox>(renderer()).hitTestClipPath(hitTestLocation, toLayoutPoint(location() - renderBoxLocation()))) > > > > Are we sure that hitTestLocation is in the correct coordinate system for the > > call to hitTestClipPath()? > > I checked that this is the same we use when we hit test through RenderObject > for the layer's outermost element. However… this looks to be the cause for bug 227624.
Note You need to log in before you can comment on or make changes to this bug.