Bug 226477

Summary: REGRESSION(r278261): Broke windows build
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226272    
Attachments:
Description Flags
REVERT of r278261
ews-feeder: commit-queue-
[fast-cq] Patch none

WebKit Commit Bot
Reported 2021-05-31 18:14:29 PDT
https://trac.webkit.org/changeset/278261 broke the build: Broke windows build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r278261 (89.01 KB, patch)
2021-05-31 18:14 PDT, WebKit Commit Bot 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] Patch (1.02 KB, patch)
2021-05-31 18:26 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2021-05-31 18:14:36 PDT
Created attachment 430220 [details] REVERT of r278261 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
EWS
Comment 2 2021-05-31 18:17:21 PDT
Committed r278290 (238327@main): <https://commits.webkit.org/238327@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430220 [details].
Radar WebKit Bug Importer
Comment 3 2021-05-31 18:18:22 PDT
<rdar://problem/78696494>
Aakash Jain
Comment 4 2021-05-31 18:25:03 PDT
Revert wasn't complete as there was a subsequent commit (r278283) which used the file (CSSCalcSymbolTable.h) added in r278261.
Aakash Jain
Comment 5 2021-05-31 18:26:07 PDT
Created attachment 430221 [details] [fast-cq] Patch
EWS
Comment 6 2021-05-31 18:35:35 PDT
Committed r278291 (238328@main): <https://commits.webkit.org/238328@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430221 [details].
Note You need to log in before you can comment on or make changes to this bug.