| Summary: | ANGLE Metal translator should clamp array access in MSL | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
| Component: | ANGLE | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, dino, ews-watchlist, graouts, johncunningham, kirtiar15502, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=226397 | ||||||
| Attachments: |
|
||||||
|
Description
Kimmo Kinnunen
2021-05-31 06:07:12 PDT
Looks like this issue was created after that, yes? Created attachment 430200 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE (In reply to Kirtikumar Anandrao Ramchandani from comment #1) > Looks like this issue was created after that, yes? This bug report was created based on bug 226397 and after that, yes. Can we write a test for this? We can write a test case to reach that particular piece of code, yes. (In reply to Dean Jackson from comment #5) > Can we write a test for this? At the moment it's a bit cumbersome. For manual inspection of shader text output we'd either need to: a) add a text-dumping translator tester to ANGLE b) implement (the long overdue) per-gpu filtering possibility to RWT and use the layout test to dump the GL/MTL shader output to expected files For draw inspection-based test it's hard to do since we don't know what to expect in the failure case. In practice we can't know that a success would indicate lack of bug. This is tested by conformance/uniforms/out-of-bounds-uniform-array-access.html but it's unclear to what extent we can observe the bug. Obviously we cannot, as the test did not trigger. I'll check if we can later turn on validating layer for Metal on Debug builds, but I doubt it will detect this either. I'll put testing this in the "back burner" and take the liberty to merge without, as we have bigger issues in testing than this. > b) implement (the long overdue) per-gpu filtering possibility to RWT and use the layout test to dump the GL/MTL shader output to expected files
Except, maybe it's doable since this the "MSL or GLSL or HLSL" decision is per platform in WebKit at the moment. I'll try to write the test.
It seems this r+ patch didn't landed. Is it something still needed or being worked on? Thanks! Thanks for the heads. I think I need to upstream this. Already fixed in GenMetalTraverser::visitBinary(Visit, TIntermBinary *binaryNode) |