Bug 226421

Summary: Split calc() related files into 1-class per file structure
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-05-29 12:12:17 PDT
Split calc() related files into proper 1-file per class structure
Attachments
Patch (319.78 KB, patch)
2021-05-29 12:17 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (319.78 KB, patch)
2021-05-29 12:22 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (321.19 KB, patch)
2021-05-29 12:26 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (321.21 KB, patch)
2021-05-29 13:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (321.19 KB, patch)
2021-05-29 13:39 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (321.20 KB, patch)
2021-05-29 13:46 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (322.00 KB, patch)
2021-05-29 14:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-05-29 12:17:22 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-05-29 12:22:34 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2021-05-29 12:26:54 PDT Comment hidden (obsolete)
Darin Adler
Comment 4 2021-05-29 13:28:41 PDT
"proper" Does seem like a great idea.
Sam Weinig
Comment 5 2021-05-29 13:38:30 PDT
(In reply to Darin Adler from comment #4) > "proper" > > Does seem like a great idea. "proper" in the British sense of course: nice, polite, respectable. :).
Sam Weinig
Comment 6 2021-05-29 13:38:43 PDT Comment hidden (obsolete)
Sam Weinig
Comment 7 2021-05-29 13:39:36 PDT Comment hidden (obsolete)
Darin Adler
Comment 8 2021-05-29 13:40:35 PDT
Comment on attachment 430107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430107&action=review > Source/WebCore/Headers.cmake:1159 > + platform/calc/CalcExpressionNode Missing ".h"?
Sam Weinig
Comment 9 2021-05-29 13:46:18 PDT Comment hidden (obsolete)
Sam Weinig
Comment 10 2021-05-29 13:46:36 PDT
(In reply to Darin Adler from comment #8) > Comment on attachment 430107 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430107&action=review > > > Source/WebCore/Headers.cmake:1159 > > + platform/calc/CalcExpressionNode > > Missing ".h"? Indeed. Fixed in the latest.
Sam Weinig
Comment 11 2021-05-29 14:03:20 PDT
Created attachment 430109 [details] Patch
Sam Weinig
Comment 12 2021-05-29 17:08:00 PDT
Ok, looks like it all compiles now. Should be ready for review.
Chris Dumez
Comment 13 2021-05-29 17:15:47 PDT
Comment on attachment 430109 [details] Patch rs=me
EWS
Comment 14 2021-05-29 17:51:32 PDT
Committed r278246 (238283@main): <https://commits.webkit.org/238283@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430109 [details].
Radar WebKit Bug Importer
Comment 15 2021-05-29 17:52:20 PDT
<rdar://problem/78654675>
Note You need to log in before you can comment on or make changes to this bug.