Bug 226421

Summary: Split calc() related files into 1-class per file structure
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Sam Weinig 2021-05-29 12:12:17 PDT 
Split calc() related files into proper 1-file per class structure
Comment 1 Sam Weinig 2021-05-29 12:17:22 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-05-29 12:22:34 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2021-05-29 12:26:54 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2021-05-29 13:28:41 PDT 
"proper"

Does seem like a great idea.
Comment 5 Sam Weinig 2021-05-29 13:38:30 PDT 
(In reply to Darin Adler from comment #4)
> "proper"
> 
> Does seem like a great idea.

"proper" in the British sense of course: nice, polite, respectable. :).
Comment 6 Sam Weinig 2021-05-29 13:38:43 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2021-05-29 13:39:36 PDT Comment hidden (obsolete)
Comment 8 Darin Adler 2021-05-29 13:40:35 PDT 
Comment on attachment 430107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430107&action=review

> Source/WebCore/Headers.cmake:1159
> +    platform/calc/CalcExpressionNode

Missing ".h"?
Comment 9 Sam Weinig 2021-05-29 13:46:18 PDT Comment hidden (obsolete)
Comment 10 Sam Weinig 2021-05-29 13:46:36 PDT 
(In reply to Darin Adler from comment #8)
> Comment on attachment 430107 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430107&action=review
> 
> > Source/WebCore/Headers.cmake:1159
> > +    platform/calc/CalcExpressionNode
> 
> Missing ".h"?

Indeed. Fixed in the latest.
Comment 11 Sam Weinig 2021-05-29 14:03:20 PDT 
Created attachment 430109 [details]
Patch
Comment 12 Sam Weinig 2021-05-29 17:08:00 PDT 
Ok, looks like it all compiles now. Should be ready for review.
Comment 13 Chris Dumez 2021-05-29 17:15:47 PDT 
Comment on attachment 430109 [details]
Patch

rs=me
Comment 14 EWS 2021-05-29 17:51:32 PDT 
Committed r278246 (238283@main): <https://commits.webkit.org/238283@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430109 [details].
Comment 15 Radar WebKit Bug Importer 2021-05-29 17:52:20 PDT 
<rdar://problem/78654675>