Bug 226403

Summary:

add window.internals.log()

Product:

WebKit

Reporter:

Cameron McCormack (:heycam) <heycam>

Component:

Tools / Tests

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Cameron McCormack (:heycam) 2021-05-28 16:05:10 PDT

I found it useful while debugging tests to have a way to output logging from within the test.

Comment 1 Cameron McCormack (:heycam) 2021-05-28 16:08:44 PDT

Created attachment 430067 [details]
Patch

Comment 2 Alexey Proskuryakov 2021-05-28 17:14:52 PDT

Comment on attachment 430067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430067&action=review

> Source/WebCore/ChangeLog:9
> +        Useful for interleaving some output generated from within a test with
> +        WebCore logging.

Could you please elaborate on how the behavior is different from window.console.log? Is this to have something in the system log?

Comment 3 Cameron McCormack (:heycam) 2021-05-28 17:39:30 PDT

This is specifically to add something to stderr.  When I was debugging a test with WebCore logging enabled, I wanted to add some markers to stderr before and after the JS stuff that I was interested in.

Comment 4 Cameron McCormack (:heycam) 2021-05-28 17:43:04 PDT

Created attachment 430079 [details]
Patch

Comment 5 Radar WebKit Bug Importer 2021-06-04 16:06:20 PDT

<rdar://problem/78890214>

Comment 6 Tim Horton 2021-06-09 17:46:10 PDT

Comment on attachment 430079 [details]
Patch

Does not seem outrageous to have a way to get to WTFLogAlways from internals.

Comment 7 EWS 2021-06-09 20:23:55 PDT

Committed r278690 (238664@main): <https://commits.webkit.org/238664@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430079 [details].