Bug 22635

Summary:

Crash when destroying element being animated in its start animation event

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Chris Marrin <cmarrin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch, including LayoutTest files	hyatt: review+

Description Simon Fraser (smfr) 2008-12-03 14:34:34 PST

We should make LayoutTests for element destruction inside onAnimationStart/onAnimationIteration event handler callbacks (e.g. see bug 22499).

Comment 1 Chris Marrin 2008-12-03 17:40:38 PST

In making the testcases for element destruction in the iteration and start events, I got a crash in the start event case. I'm fixing it now. I'll send in the new tests along with the fix.

Comment 2 Chris Marrin 2008-12-03 17:56:21 PST

Created attachment 25729 [details]
Patch, including LayoutTest files

Comment 3 Dave Hyatt 2008-12-05 13:22:34 PST

Comment on attachment 25729 [details]
Patch, including LayoutTest files

r=me

Comment 4 Chris Marrin 2008-12-05 17:42:35 PST

Sending        LayoutTests/ChangeLog
Adding         LayoutTests/animations/animation-iteration-event-destroy-renderer-expected.txt
Adding         LayoutTests/animations/animation-iteration-event-destroy-renderer.html
Adding         LayoutTests/animations/animation-start-event-destroy-renderer-expected.txt
Adding         LayoutTests/animations/animation-start-event-destroy-renderer.html
Sending        WebCore/ChangeLog
Sending        WebCore/page/animation/AnimationBase.cpp
Sending        WebCore/page/animation/AnimationController.cpp
Sending        WebCore/page/animation/CompositeAnimation.cpp
Sending        WebCore/page/animation/CompositeAnimation.h
Transmitting file data ..........
Committed revision 39059.