Bug 226346

Summary: [Hardening] Use a RELEASE_ASSERT for SharedBufferDataView constructor
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ddkilzer, fpizlo, keith_miller, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2021-05-27 11:05:38 PDT
We have a DEBUG assert in the constructor for SharedBufferDataView. Debug test bots don't hit this, and it's not a particularly hot code path. We should make it a release assert.
Attachments
Patch (1.57 KB, patch)
2021-05-27 13:04 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2021-05-27 11:05:59 PDT
<rdar://problem/78115298>
Brent Fulgham
Comment 2 2021-05-27 13:04:30 PDT
Created attachment 429914 [details] Patch
EWS
Comment 3 2021-05-27 16:03:41 PDT
Committed r278180 (238223@main): <https://commits.webkit.org/238223@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429914 [details].
Note You need to log in before you can comment on or make changes to this bug.