Summary: | Add stub implementation of CA separated portal bits for GraphicsLayer | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, sergio, simon.fraser, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sam Weinig
2021-05-27 10:16:14 PDT
Created attachment 429895 [details]
Patch
Comment on attachment 429895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429895&action=review > Source/WTF/ChangeLog:3 > + Add stub implementation of CA seperated portal bits for GraphicsLayer separated Created attachment 429902 [details]
Patch
Comment on attachment 429902 [details]
Patch
Seems OK. Not sure about the -is prefix on the getters, and would be good for smfr to peek.
Comment on attachment 429902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429902&action=review > Source/WebCore/ChangeLog:8 > + Plumbs isSeparatedPortal and isDescendentOfSeparatedPortal bits through GraphicsLayer. Plumbs > Source/WebCore/platform/graphics/GraphicsLayer.h:406 > + virtual void setIsDescendentOfSeparatedPortal(bool b) { m_isDescendentOfSeparatedPortal = b; } Does this need to be exposed? We can compute this internally in GraphicsLayer while flushing. > Source/WebCore/platform/graphics/GraphicsLayer.h:744 > + bool m_isSeparatedPortal : 1; There's some ambiguity here. Does m_isSeparatedPortal being true imply that m_isSeparated is also true? (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 429902 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429902&action=review > > > Source/WebCore/ChangeLog:8 > > + Plumbs isSeparatedPortal and isDescendentOfSeparatedPortal bits through GraphicsLayer. > > Plumbs > > > Source/WebCore/platform/graphics/GraphicsLayer.h:406 > > + virtual void setIsDescendentOfSeparatedPortal(bool b) { m_isDescendentOfSeparatedPortal = b; } > > Does this need to be exposed? We can compute this internally in > GraphicsLayer while flushing. You are right, probably not. > > > Source/WebCore/platform/graphics/GraphicsLayer.h:744 > > + bool m_isSeparatedPortal : 1; > > There's some ambiguity here. Does m_isSeparatedPortal being true imply that > m_isSeparated is also true? It's currently meant only to be valid when m_isSeparated is true. I don't want to merge it into an enum yet though, as depending on where things go, this may become non-separated requiring. Created attachment 429927 [details]
Patch
Committed r278217 (238256@main): <https://commits.webkit.org/238256@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429927 [details]. |