Bug 226338

Summary: Prevent resetting scroll position in unnecessary cases during page load
Product: WebKit Reporter: Matt Gilligan <matthew_gilligan>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: matthew_gilligan, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Matt Gilligan
Reported 2021-05-27 09:44:19 PDT
Prevent resetting scroll position in unnecessary cases during page load
Attachments
Patch (8.05 KB, patch)
2021-05-27 10:24 PDT, Matt Gilligan 		no flags
DetailsFormatted DiffDiff
Patch (8.06 KB, patch)
2021-05-28 10:23 PDT, Matt Gilligan 		no flags
DetailsFormatted DiffDiff
Patch (8.06 KB, patch)
2021-05-28 12:30 PDT, Matt Gilligan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matt Gilligan
Comment 1 2021-05-27 09:45:52 PDT
<rdar://75334651>
Matt Gilligan
Comment 2 2021-05-27 10:24:50 PDT
Created attachment 429896 [details] Patch
Wenson Hsieh
Comment 3 2021-05-28 09:33:22 PDT
Comment on attachment 429896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429896&action=review > Tools/TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:265 > + [webView scrollView].refreshControl = [[UIRefreshControl alloc] init]; Nit - might be good to fix this leak, either by autoreleasing, or with adoptNS([[UIRefreshControl alloc] init]).get()
Matt Gilligan
Comment 4 2021-05-28 10:23:15 PDT
Created attachment 430026 [details] Patch
Matt Gilligan
Comment 5 2021-05-28 12:30:50 PDT
Created attachment 430041 [details] Patch
EWS
Comment 6 2021-05-28 13:18:08 PDT
Committed r278225 (238263@main): <https://commits.webkit.org/238263@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430041 [details].
Note You need to log in before you can comment on or make changes to this bug.