Bug 226338

Summary:

Prevent resetting scroll position in unnecessary cases during page load

Product:

WebKit

Reporter:

Matt Gilligan <matthew_gilligan>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

matthew_gilligan, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Matt Gilligan 2021-05-27 09:44:19 PDT

Prevent resetting scroll position in unnecessary cases during page load

Comment 1 Matt Gilligan 2021-05-27 09:45:52 PDT

<rdar://75334651>

Comment 2 Matt Gilligan 2021-05-27 10:24:50 PDT

Created attachment 429896 [details]
Patch

Comment 3 Wenson Hsieh 2021-05-28 09:33:22 PDT

Comment on attachment 429896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429896&action=review

> Tools/TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:265
> +    [webView scrollView].refreshControl = [[UIRefreshControl alloc] init];

Nit - might be good to fix this leak, either by autoreleasing, or with adoptNS([[UIRefreshControl alloc] init]).get()

Comment 4 Matt Gilligan 2021-05-28 10:23:15 PDT

Created attachment 430026 [details]
Patch

Comment 5 Matt Gilligan 2021-05-28 12:30:50 PDT

Created attachment 430041 [details]
Patch

Comment 6 EWS 2021-05-28 13:18:08 PDT

Committed r278225 (238263@main): <https://commits.webkit.org/238263@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430041 [details].