Bug 226337 – Enforce a quota in window.sessionStorage

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Sam Sneddon [:gsnedders]]

<rdar://78507096>

Per wpt.fyi this has been happening for a while. Interestingly storage_local_setitem_quotaexceedederr.window.html (i.e., the localStorage variant) passes.

[Radar WebKit Bug Importer]

<rdar://problem/78572282>

[Sam Sneddon [:gsnedders]]

<rdar://78507096>

[Brady Eidson]

We need to add a sessionStorage quota to both pass the test and fix the crash.

[Brady Eidson]

Created attachment 430536 [details]
Patch

[Chris Dumez]

Comment on attachment 430536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430536&action=review

> LayoutTests/storage/domstorage/quota.html:-57
> -function testNoQuota(storageString)

You'll likely need to update LayoutTests//platform/ios/ios/storage/domstorage/5mb-quota.html too.

[Chris Dumez]

(In reply to Chris Dumez from comment #5)
> Comment on attachment 430536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430536&action=review
> 
> > LayoutTests/storage/domstorage/quota.html:-57
> > -function testNoQuota(storageString)
> 
> You'll likely need to update
> LayoutTests//platform/ios/ios/storage/domstorage/5mb-quota.html too.

BTW, I am not quite sure why we have an iOS-specific test. Maybe we can drop it if the behavior isn't any different on macOS and iOS.

[Chris Dumez]

Comment on attachment 430536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430536&action=review

> LayoutTests/ChangeLog:8
> +        * storage/domstorage/quota.html:

Looks like this test needs to be rebaselined too.

[Brady Eidson]

(In reply to Chris Dumez from comment #7)
> Comment on attachment 430536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430536&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        * storage/domstorage/quota.html:
> 
> Looks like this test needs to be rebaselined too.
(In reply to Chris Dumez from comment #6)
> (In reply to Chris Dumez from comment #5)
> > Comment on attachment 430536 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=430536&action=review
> > 
> > > LayoutTests/storage/domstorage/quota.html:-57
> > > -function testNoQuota(storageString)
> > 
> > You'll likely need to update
> > LayoutTests//platform/ios/ios/storage/domstorage/5mb-quota.html too.
> 
> BTW, I am not quite sure why we have an iOS-specific test. Maybe we can drop
> it if the behavior isn't any different on macOS and iOS.


After I uploaded is when I discovered the iOS test locally. UIWebView enforced a 5mb quota.

We can drop it now.

> > LayoutTests/ChangeLog:8
> > +        * storage/domstorage/quota.html:
>
> Looks like this test needs to be rebaselined too.

Passed locally, so yah I'll figure it out *sigh*

[Brady Eidson]

Created attachment 430596 [details]
PFL

[EWS]

Committed r278498 (238505@main): <https://commits.webkit.org/238505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430596 [details].