Bug 226315

Summary: [LFC] Transition containing block 'for' loops to range loops
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226379    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2021-05-26 20:55:27 PDT 
ssia
Comment 1 zalan 2021-05-26 21:03:03 PDT 
Created attachment 429840 [details]
Patch
Comment 2 zalan 2021-05-27 15:49:56 PDT 
Created attachment 429946 [details]
Patch
Comment 3 zalan 2021-05-27 16:14:53 PDT 
Created attachment 429947 [details]
Patch
Comment 4 Antti Koivisto 2021-05-28 06:37:20 PDT 
Comment on attachment 429947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429947&action=review

> Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:235
> +        for (auto& ancestor : containingBlockChain(layoutBox, root()))

I like how you are utilizing block chain technology here.

Might consider a helper for this case, "containingBlockChainWithinFormattingContext" or similar.
Comment 5 zalan 2021-05-28 06:48:27 PDT 
Created attachment 430008 [details]
Patch
Comment 6 zalan 2021-05-28 06:48:45 PDT 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 429947 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429947&action=review
> 
> > Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:235
> > +        for (auto& ancestor : containingBlockChain(layoutBox, root()))
> 
> I like how you are utilizing block chain technology here.
> 
> Might consider a helper for this case,
> "containingBlockChainWithinFormattingContext" or similar.
Good idea!
Comment 7 EWS 2021-05-28 07:20:11 PDT 
Committed r278196 (238239@main): <https://commits.webkit.org/238239@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430008 [details].
Comment 8 Radar WebKit Bug Importer 2021-05-28 07:21:17 PDT 
<rdar://problem/78617306>
Comment 9 WebKit Commit Bot 2021-05-28 09:25:22 PDT 
Re-opened since this is blocked by bug 226379
Comment 10 zalan 2021-05-28 21:24:28 PDT 
Created attachment 430088 [details]
Patch
Comment 11 EWS 2021-05-29 05:12:17 PDT 
Committed r278238 (238275@main): <https://commits.webkit.org/238275@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430088 [details].