Bug 226315

Summary: [LFC] Transition containing block 'for' loops to range loops
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226379    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2021-05-26 20:55:27 PDT
ssia
Attachments
Patch (16.52 KB, patch)
2021-05-26 21:03 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.99 KB, patch)
2021-05-27 15:49 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.02 KB, patch)
2021-05-27 16:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.34 KB, patch)
2021-05-28 06:48 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.38 KB, patch)
2021-05-28 21:24 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-05-26 21:03:03 PDT
Created attachment 429840 [details] Patch
alan
Comment 2 2021-05-27 15:49:56 PDT
Created attachment 429946 [details] Patch
alan
Comment 3 2021-05-27 16:14:53 PDT
Created attachment 429947 [details] Patch
Antti Koivisto
Comment 4 2021-05-28 06:37:20 PDT
Comment on attachment 429947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429947&action=review > Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:235 > + for (auto& ancestor : containingBlockChain(layoutBox, root())) I like how you are utilizing block chain technology here. Might consider a helper for this case, "containingBlockChainWithinFormattingContext" or similar.
alan
Comment 5 2021-05-28 06:48:27 PDT
Created attachment 430008 [details] Patch
alan
Comment 6 2021-05-28 06:48:45 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 429947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429947&action=review > > > Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:235 > > + for (auto& ancestor : containingBlockChain(layoutBox, root())) > > I like how you are utilizing block chain technology here. > > Might consider a helper for this case, > "containingBlockChainWithinFormattingContext" or similar. Good idea!
EWS
Comment 7 2021-05-28 07:20:11 PDT
Committed r278196 (238239@main): <https://commits.webkit.org/238239@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430008 [details].
Radar WebKit Bug Importer
Comment 8 2021-05-28 07:21:17 PDT
<rdar://problem/78617306>
WebKit Commit Bot
Comment 9 2021-05-28 09:25:22 PDT
Re-opened since this is blocked by bug 226379
alan
Comment 10 2021-05-28 21:24:28 PDT
Created attachment 430088 [details] Patch
EWS
Comment 11 2021-05-29 05:12:17 PDT
Committed r278238 (238275@main): <https://commits.webkit.org/238275@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430088 [details].
Note You need to log in before you can comment on or make changes to this bug.