Bug 226289

Summary: Do not skip SetCommitQueueMinusFlagOnPatch step on EWS test instances
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch none

Aakash Jain
Reported 2021-05-26 13:36:42 PDT
SetCommitQueueMinusFlagOnPatch step does two things: 1) set cq- flag on bugzilla bug 2) mark the build as completed Since r273090, this step is skipped on EWS test instances (e.g.: ews-build.webkit-uat.org). However, skipping the part about marking the build complete, causes the build to run extra steps which it shouldn't be running (e.g.: step 20 in https://ews-build.webkit-uat.org/#/builders/34/builds/31441). We shouldn't skip the entire SetCommitQueueMinusFlagOnPatch step on EWS test instances, we should only skip relevant portion about Bugzilla interaction.
Attachments
[fast-cq] Patch (1.76 KB, patch)
2021-05-26 13:39 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-05-26 13:39:06 PDT
Created attachment 429790 [details] [fast-cq] Patch
Aakash Jain
Comment 2 2021-05-26 13:40:17 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/34/builds/31444
EWS
Comment 3 2021-05-26 14:05:24 PDT
Committed r278124 (238174@main): <https://commits.webkit.org/238174@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429790 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-26 14:06:21 PDT
<rdar://problem/78531277>
Note You need to log in before you can comment on or make changes to this bug.