Bug 226264

Summary: [JSC] cloop again broken on 32-bit big endian in 2.32.x
Product: WebKit Reporter: Nina Kolesa <nina>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch none

Nina Kolesa
Reported 2021-05-26 04:31:15 PDT
It seems a change was missed. Patch incoming.
Attachments
patch (1.95 KB, patch)
2021-05-26 04:32 PDT, Nina Kolesa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nina Kolesa
Comment 1 2021-05-26 04:32:23 PDT
Created attachment 429747 [details] patch patch
Caio Lima
Comment 2 2021-05-26 05:39:47 PDT
Comment on attachment 429747 [details] patch r=me
Caio Lima
Comment 3 2021-05-26 05:42:55 PDT
I’m a bit surprised that we are running JSC on 32-bits big endian platforms. Maybe we should add a post-commit buildbot at some point? There’s a couple of places I worked on 32-bits LLInt where I considered little-endian only, so we might have other bugs like that around. Also, without test feedback, it will be quite likely that we will introduce bugs like that in the future.
Nina Kolesa
Comment 4 2021-05-26 05:55:12 PDT
i'll definitely run the tests at one point (on powerpc 64le, 64be, 32be) though at this point the big endian platforms are a best-effort thing in my distribution, so i'm not able to invest more time than right now into them... but yeah things are known to work okay currently (at very least, it never crashes the web process, there may be buggy javascript on some sites - e.g. google maps js throws exceptions when trying to render tiles right now - but some quite complex webapps are known to work okay)
Adrian Perez
Comment 5 2021-05-26 09:20:49 PDT
Should we cq+ this?
Adrian Perez
Comment 6 2021-05-27 02:53:26 PDT
Comment on attachment 429747 [details] patch Setting cq+ to land in trunk, so I can backport it to the release branch
EWS
Comment 7 2021-05-27 02:56:59 PDT
Committed r278157 (238201@main): <https://commits.webkit.org/238201@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429747 [details].
Radar WebKit Bug Importer
Comment 8 2021-05-27 02:57:16 PDT
<rdar://problem/78560223>
Note You need to log in before you can comment on or make changes to this bug.