Scrollbars/indicators are sometimes incorrectly drawn when async overflow scrolling is enabled

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Chris Lord]

Some tests are failing on WPE since enabling async overflow scrolling in tests due to incorrect drawing of scrollbars/indicators.

[Chris Lord]

Created attachment 429736 [details]
Patch

[Chris Lord]

Comment on attachment 429736 [details]
Patch

Obviously not quite there yet.

[Chris Lord]

Created attachment 429754 [details]
Patch

[Chris Lord]

Comment on attachment 429754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429754&action=review

> Source/WebCore/ChangeLog:8
> +        Respect clipped overflow when deciding whether to create layers for

The ChangeLog entry should read:

"Respect scrolled contents visibility when rendering scrollbar layers."

[Simon Fraser (smfr)]

Comment on attachment 429754 [details]
Patch

Odd that this doesn't affect macOS behavior.

[Chris Lord]

(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 429754 [details]
> Patch
> 
> Odd that this doesn't affect macOS behavior.

I guess Mac doesn't run tests with async overflow scrolling enabled? Or implements it differently somehow? I think that's either the only thing that hit this path incorrectly, or at least the most common thing. Same goes for bug 225922, and I guess the failures in bug 224596.

[Chris Lord]

Created attachment 429801 [details]
Patch

[EWS]

Committed r278129 (238179@main): <https://commits.webkit.org/238179@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429801 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78536929>