Bug 226257

Summary: takeSnapshotWithConfiguration() should wait for the next flush before it does callSnapshotRect()
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226949
https://bugs.webkit.org/show_bug.cgi?id=227318
https://bugs.webkit.org/show_bug.cgi?id=230085
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Said Abou-Hallawa
Reported 2021-05-25 23:28:22 PDT
This will ensure the latest IOSurfaces are pushed to backboardd before taking the snapshot.
Attachments
Patch (2.20 KB, patch)
2021-05-25 23:32 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2021-06-10 13:16 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2021-06-16 12:31 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2021-06-16 12:49 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-05-25 23:30:51 PDT
<rdar://76411685>
Said Abou-Hallawa
Comment 2 2021-05-25 23:32:26 PDT
Created attachment 429732 [details] Patch
Said Abou-Hallawa
Comment 3 2021-06-10 13:16:59 PDT
Created attachment 431117 [details] Patch
EWS
Comment 4 2021-06-10 22:03:24 PDT
Committed r278754 (238715@main): <https://commits.webkit.org/238715@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431117 [details].
Ryan Haddad
Comment 5 2021-06-11 21:16:15 PDT
Reverting this because it cause iOS API test failures that are backing up EWS (sadly, we didn't get iOS API test EWS coverage for this patch because of another pre-existing failure) (see https://bugs.webkit.org/show_bug.cgi?id=226949)
Ryan Haddad
Comment 6 2021-06-11 21:16:42 PDT
Reverted r278754 for reason: Caused 5 TestWebKitAPI.WKWebView.SnapshotImage* tests to time out on iOS Committed r278807 (238764@main): <https://commits.webkit.org/238764@main>
Said Abou-Hallawa
Comment 7 2021-06-16 12:31:27 PDT
Created attachment 431585 [details] Patch
Said Abou-Hallawa
Comment 8 2021-06-16 12:49:05 PDT
Created attachment 431587 [details] Patch
EWS
Comment 9 2021-06-16 17:46:48 PDT
Committed r278970 (238896@main): <https://commits.webkit.org/238896@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431587 [details].
Note You need to log in before you can comment on or make changes to this bug.