Bug 226244 – [WPE][GTK] Support building against uClibc

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

After the fixes from bug #210068 and bug #225099 it's *almost*
possible to build the GTK and WPE ports against uClibc—the Musl
fixes also benefited uClibc :)

There are a couple of things to fix for uClibc, though.

[Adrian Perez]

Created attachment 429702 [details]
Patch

[Michael Catanzaro]

Comment on attachment 429702 [details]
Patch

Unfortunately we're almost guaranteed to have unknown glibc-specific assumptions that will result in incorrect behavior at runtime hidden throughout WebKit. I guess the first step to finding them is to make it build.

E.g. one fun problem we used to have was gspawn relied on malloc being async-signal-safe, so subprocess launching would randomly fail with other C libraries , but only if you're sufficiently unlucky. That was eventually fixed in fairly recent versions of glib. Point is: similar problems will be out there....

[EWS]

Committed r278302 (238339@main): <https://commits.webkit.org/238339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429702 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78711308>

[Adrian Perez]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 429702 [details]
> Patch
> 
> Unfortunately we're almost guaranteed to have unknown glibc-specific
> assumptions that will result in incorrect behavior at runtime hidden
> throughout WebKit. I guess the first step to finding them is to make it
> build.
> 
> E.g. one fun problem we used to have was gspawn relied on malloc being
> async-signal-safe, so subprocess launching would randomly fail with other C
> libraries , but only if you're sufficiently unlucky. That was eventually
> fixed in fairly recent versions of glib. Point is: similar problems will be
> out there....

While I had *not* done a full run of layout tests with an uClibc build,
I did submit this patch to Buildroot and did an ARM64 build which I smoke
tested for a while without issues. The recent changes that were done for
Musl also helped for uClibc, as a matter of fact, and while it is likely
that some tests would fail with an uClibc build, it seems usable in practice.

Here's the Buildroot patches needed to have the WPE and GTK ports built
with uClibc, for reference:

  https://patchwork.ozlabs.org/project/buildroot/patch/[e-mail]/
  https://patchwork.ozlabs.org/project/buildroot/patch/[e-mail]/

:)