Bug 226228

Summary: Introduce a shared IDB serialization thread
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: WebCore Misc.Assignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, ggaren, jsbell, mark.lam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Sihui Liu
Reported 2021-05-25 11:56:18 PDT
...
Attachments
Patch (29.92 KB, patch)
2021-05-25 12:34 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (29.88 KB, patch)
2021-05-25 15:01 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (30.05 KB, patch)
2021-05-25 15:37 PDT, Sihui Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (30.03 KB, patch)
2021-05-25 16:10 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.33 KB, patch)
2021-06-02 20:44 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-05-25 12:34:25 PDT
Created attachment 429677 [details] Patch
Sihui Liu
Comment 2 2021-05-25 15:01:08 PDT
Created attachment 429697 [details] Patch
Sihui Liu
Comment 3 2021-05-25 15:37:07 PDT
Created attachment 429701 [details] Patch
Sihui Liu
Comment 4 2021-05-25 16:10:02 PDT
Created attachment 429705 [details] Patch
Chris Dumez
Comment 5 2021-05-26 07:52:33 PDT
Comment on attachment 429705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429705&action=review We may want to add threading assertions to the serialization / deserialization functions to make sure they are called on the expected thread? > Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:428 > + IDBSerializationContext() Please make constructor private and add a create() factory function, like we do for all RefCounted classes. Or maybe even better, don't subclass RefCounted and use a stack object? It is unclear why this is RefCounted based on how it is used currently.
Radar WebKit Bug Importer
Comment 6 2021-06-01 11:57:19 PDT
<rdar://problem/78725516>
Sihui Liu
Comment 7 2021-06-02 20:44:16 PDT
Created attachment 430442 [details] Patch for landing
EWS
Comment 8 2021-06-02 21:57:52 PDT
Committed r278393 (238418@main): <https://commits.webkit.org/238418@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430442 [details].
Note You need to log in before you can comment on or make changes to this bug.