Bug 226206

Summary: Stop using UncheckedLock in WTF::RecursiveLock
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cmarcelo, darin, ews-watchlist, ggaren, kkinnunen, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-05-24 19:10:22 PDT 
Stop using UncheckedLock in WTF::RecursiveLock and use a regular Lock instead. This is a step towards phasing out UncheckedLock.
Comment 1 Chris Dumez 2021-05-24 19:12:53 PDT 
Created attachment 429611 [details]
Patch
Comment 2 Sam Weinig 2021-05-24 20:13:10 PDT 
Comment on attachment 429611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429611&action=review

> Source/WTF/wtf/RecursiveLockAdapter.h:38
> +    void lock() WTF_IGNORES_THREAD_SAFETY_ANALYSIS

I think a comment explaining why this is being added would go a long way here.
Comment 3 Chris Dumez 2021-05-24 20:20:28 PDT 
Created attachment 429620 [details]
Patch
Comment 4 EWS 2021-05-24 20:59:56 PDT 
Committed r277995 (238108@main): <https://commits.webkit.org/238108@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429620 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-24 21:00:18 PDT 
<rdar://problem/78434523>