Bug 226186

Summary: Stop using UncheckedLock in html/canvas
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, changseok, cmarcelo, darin, dino, esprehn+autocc, ews-watchlist, ggaren, graouts, gyuyoung.kim, kkinnunen, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-05-24 13:28:01 PDT
Stop using UncheckedLock in html/canvas. This is work towards phasing out UncheckedLock, in favor of the checked Lock type.
Attachments
Patch (10.98 KB, patch)
2021-05-24 14:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.04 KB, patch)
2021-05-24 14:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.48 KB, patch)
2021-05-24 14:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.68 KB, patch)
2021-05-24 15:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-24 14:10:45 PDT
Created attachment 429563 [details] Patch
Chris Dumez
Comment 2 2021-05-24 14:12:06 PDT
Created attachment 429564 [details] Patch
Chris Dumez
Comment 3 2021-05-24 14:14:43 PDT
Created attachment 429566 [details] Patch
Chris Dumez
Comment 4 2021-05-24 15:09:16 PDT
Created attachment 429570 [details] Patch
Chris Dumez
Comment 5 2021-05-25 09:59:09 PDT
Comment on attachment 429570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429570&action=review > Source/WTF/wtf/Lock.h:183 > +class WTF_CAPABILITY_SCOPED_LOCK Locker<Lock> : public AbstractLocker { Note that these changes to Locker<Lock> to more closely match the generic Locker<T> will be required to stop using UncheckedLock in JSC too.
Chris Dumez
Comment 6 2021-05-25 15:59:24 PDT
ping review? I'd love to make some progress phasing out UncheckedLock.
Chris Dumez
Comment 7 2021-05-25 16:19:29 PDT
Comment on attachment 429570 [details] Patch Clearing flags on attachment: 429570 Committed r278057 (238141@main): <https://commits.webkit.org/238141@main>
Chris Dumez
Comment 8 2021-05-25 16:19:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2021-05-25 16:23:14 PDT
<rdar://problem/78482248>
Note You need to log in before you can comment on or make changes to this bug.