Bug 226186

Summary: Stop using UncheckedLock in html/canvas
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, changseok, cmarcelo, darin, dino, esprehn+autocc, ews-watchlist, ggaren, graouts, gyuyoung.kim, kkinnunen, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-05-24 13:28:01 PDT 
Stop using UncheckedLock in html/canvas. This is work towards phasing out UncheckedLock, in favor of the checked Lock type.
Comment 1 Chris Dumez 2021-05-24 14:10:45 PDT 
Created attachment 429563 [details]
Patch
Comment 2 Chris Dumez 2021-05-24 14:12:06 PDT 
Created attachment 429564 [details]
Patch
Comment 3 Chris Dumez 2021-05-24 14:14:43 PDT 
Created attachment 429566 [details]
Patch
Comment 4 Chris Dumez 2021-05-24 15:09:16 PDT 
Created attachment 429570 [details]
Patch
Comment 5 Chris Dumez 2021-05-25 09:59:09 PDT 
Comment on attachment 429570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429570&action=review

> Source/WTF/wtf/Lock.h:183
> +class WTF_CAPABILITY_SCOPED_LOCK Locker<Lock> : public AbstractLocker {

Note that these changes to Locker<Lock> to more closely match the generic Locker<T> will be required to stop using UncheckedLock in JSC too.
Comment 6 Chris Dumez 2021-05-25 15:59:24 PDT 
ping review? I'd love to make some progress phasing out UncheckedLock.
Comment 7 Chris Dumez 2021-05-25 16:19:29 PDT 
Comment on attachment 429570 [details]
Patch

Clearing flags on attachment: 429570

Committed r278057 (238141@main): <https://commits.webkit.org/238141@main>
Comment 8 Chris Dumez 2021-05-25 16:19:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2021-05-25 16:23:14 PDT 
<rdar://problem/78482248>