Summary: | QtWebKit MinGW does not link | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, vestbo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Laszlo Gombos
2008-12-02 22:01:14 PST
Created attachment 25700 [details]
Fix
The included patch fixes the following problems/adds the following features:
- Try to detect if sqlite3.c is available as part of a Qt installation, or specified by SQLITE3SRCDIR
- When not building inside Qt only disable ENABLE_DATABASE on windows, if sqlite3.c is not available (instead of all the time)
- When ENABLE_DATABASE is disabled, disable ENABLE_OFFLINE_WEB_APPLICATIONS and ENABLE_DOM_STORAGE as well, not only ENABLE_ICONDATABASE
- ENABLE_DATABASE is now disabled by default if ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_DOM_STORAGE and ENABLE_ICONDATABASE all disabled (I have not changed however the default values for NABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_DOM_STORAGE and ENABLE_ICONDATABASE features.)
- Consolidated build logic so that there is only one code branch where sqlite3.c gets added to the source list. In addition copied SQLITE DEFINES from sqlite.pro, these were not there before.
Comment on attachment 25700 [details]
Fix
Good catch, thanks for the cleanups!
|