Bug 226177

Summary:

[LayoutTests] Delete php tests from imported/blink

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, gsnedders, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226032

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2021-05-24 08:25:38 PDT

It's possible for us to update these tests to use Python, but given that these tests were imported from blink, and given that we declined to import failing test, it seems better to simple delete the tests which rely on PHP.

Comment 1 Radar WebKit Bug Importer 2021-05-24 08:26:07 PDT

<rdar://problem/78401190>

Comment 2 Jonathan Bedard 2021-05-24 08:42:07 PDT

Created attachment 429535 [details]
Patch

Comment 3 Jonathan Bedard 2021-05-24 08:45:12 PDT

The tests being removed:
    imported/blink/http/tests/css/remove-placeholder-styles.html
    imported/blink/http/tests/security/referrer-policy-attribute-img-origin-when-crossorigin.html
    imported/blink/http/tests/security/referrer-policy-attribute-img-origin.html
    imported/blink/http/tests/security/referrer-policy-attribute-img-picture.html
    imported/blink/http/tests/security/referrer-policy-attribute-img-removeattr.html
    imported/blink/http/tests/security/referrer-policy-attribute-img-unsafe-url.html
    imported/blink/http/tests/svg/image-fetch-fail.svg

Comment 4 Jonathan Bedard 2021-05-24 10:28:31 PDT

(In reply to Jonathan Bedard from comment #3)
> The tests being removed:
>     imported/blink/http/tests/css/remove-placeholder-styles.html

No replacement, but never worked the way the author thought it did anyways (PHP is the css directory is totally inert)

>     imported/blink/http/tests/security/referrer-policy-attribute-img-origin-when-crossorigin.html
>     imported/blink/http/tests/security/referrer-policy-attribute-img-origin.html
>     imported/blink/http/tests/security/referrer-policy-attribute-img-picture.html
>     imported/blink/http/tests/security/referrer-policy-attribute-img-removeattr.html
>     imported/blink/http/tests/security/referrer-policy-attribute-img-unsafe-url.html

Much more thorough implementations of this in http/tests/referrer-policy-img

>     imported/blink/http/tests/svg/image-fetch-fail.svg

Looks to be covered in more detail by imported/w3c/web-platform-tests/svg

Comment 5 Jonathan Bedard 2021-05-24 10:29:29 PDT

(In reply to Jonathan Bedard from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > The tests being removed:
> >     imported/blink/http/tests/css/remove-placeholder-styles.html
> 
> No replacement, but never worked the way the author thought it did anyways
> (PHP is the css directory is totally inert)

Oh, wait, never mind, in http/tests

Comment 6 Jonathan Bedard 2021-05-24 10:31:36 PDT

(In reply to Jonathan Bedard from comment #5)
> (In reply to Jonathan Bedard from comment #4)
> > (In reply to Jonathan Bedard from comment #3)
> > > The tests being removed:
> > >     imported/blink/http/tests/css/remove-placeholder-styles.html
> > 
> > No replacement, but never worked the way the author thought it did anyways
> > (PHP is the css directory is totally inert)
> 
> Oh, wait, never mind, in http/tests

imported/blink/http/tests/css/remove-placeholder-styles.html looks to be a duplicate of http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html

Comment 7 EWS 2021-05-26 10:40:42 PDT

Committed r278092 (238167@main): <https://commits.webkit.org/238167@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429535 [details].