Bug 226176

Summary: Drop CheckedLock / CheckedCondition aliases
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, achristensen, alecflett, annulen, apinheiro, beidson, benjamin, calvaris, cfleizach, cgarcia, changseok, cmarcelo, darin, ddkilzer, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, ggaren, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, katherine_cheney, keith_miller, kkinnunen, kondapallykalyan, luiz, mark.lam, menard, mmaxfield, msaboff, philipj, pnormand, ryuan.choi, saam, samuel_white, sam, sergio, simon.fraser, tommyw, tonikitoo, toyoshim, tzagallo, vjaquez, webkit-bug-importer, yutak, zeno
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226157    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch katherine_cheney: review+

Chris Dumez
Reported 2021-05-24 08:16:00 PDT
Drop CheckedLock / CheckedCondition aliases now that they are the default.
Attachments
Patch (284.33 KB, patch)
2021-05-24 08:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (186.08 KB, patch)
2021-05-24 08:28 PDT, Chris Dumez 		katherine_cheney: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-24 08:19:27 PDT
Created attachment 429532 [details] Patch
Chris Dumez
Comment 2 2021-05-24 08:28:53 PDT
Created attachment 429533 [details] Patch
Kate Cheney
Comment 3 2021-05-24 11:21:11 PDT
Comment on attachment 429533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429533&action=review > Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:40 > +#include <wtf/Lock.h> Extra #include <wtf/Lock.h> I think.
Chris Dumez
Comment 4 2021-05-24 11:29:13 PDT
Committed r277958 (238085@main): <https://commits.webkit.org/238085@main>
Chris Dumez
Comment 5 2021-05-24 11:29:50 PDT
(In reply to katherine_cheney from comment #3) > Comment on attachment 429533 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429533&action=review > > > Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:40 > > +#include <wtf/Lock.h> > > Extra #include <wtf/Lock.h> I think. Thanks for reviewing! You were right and I fixed it before landing.
Radar WebKit Bug Importer
Comment 6 2021-05-24 11:30:26 PDT
<rdar://problem/78410657>
Note You need to log in before you can comment on or make changes to this bug.