Summary: | Add modal dialog UA styles | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||||
Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | allan.jensen, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 226169, 227522 | ||||||||||
Bug Blocks: | 84635 | ||||||||||
Attachments: |
|
Description
Tim Nguyen (:ntim)
2021-05-24 07:00:19 PDT
Created attachment 432582 [details]
Patch
Created attachment 432591 [details]
Patch
Comment on attachment 432591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432591&action=review > Source/WebCore/css/dialog.css:25 > + max-width: calc(100% - 6px - 2em); > + max-height: calc(100% - 6px - 2em); Where did these come from? Created attachment 432605 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 432591 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432591&action=review > > > Source/WebCore/css/dialog.css:25 > > + max-width: calc(100% - 6px - 2em); > > + max-height: calc(100% - 6px - 2em); > > Where did these come from? As wonky as they are, they are actually from the spec, see comment 0. Committed r279414 (239279@main): <https://commits.webkit.org/239279@main> |