Bug 226165

Summary:

[CoordinatedGraphics] Handle null native surface handle for surfaceless rendering

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ews-watchlist, gyuyoung.kim, luiz, pnormand, ryuan.choi, sergio, webkit-bug-importer, zdobersek, zeno

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2021-05-24 00:36:49 PDT

[CoordinatedGraphics] Handle null native window handle for surfaceless rendering

Comment 1 Zan Dobersek 2021-05-24 00:42:31 PDT

Created attachment 429509 [details]
Patch

Comment 2 Philippe Normand 2021-05-24 08:20:10 PDT

Comment on attachment 429509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429509&action=review

> Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:74
> +        if (m_context) {

Nit: this could be reversed and early return.

Comment 3 EWS 2021-05-24 23:14:53 PDT

Committed r277998 (238111@main): <https://commits.webkit.org/238111@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429509 [details].

Comment 4 Radar WebKit Bug Importer 2021-05-24 23:15:19 PDT

<rdar://problem/78439250>