Bug 226160

Summary: DestinationColorSpace's well known color space accessors cause unnecessary retain count churn
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+, ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-05-23 18:07:45 PDT
DestinationColorSpace's well known color space accessors cause unnecessary retain count churn
Attachments
Patch (4.49 KB, patch)
2021-05-23 18:10 PDT, Sam Weinig 		darin: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.46 KB, patch)
2021-05-24 19:53 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-05-23 18:10:38 PDT
Created attachment 429492 [details] Patch
Darin Adler
Comment 2 2021-05-24 14:24:49 PDT
Comment on attachment 429492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429492&action=review > Source/WebCore/platform/graphics/DestinationColorSpace.cpp:41 > +template<KnownColorSpaceAccessor knownColorSpaceAccessor> static const DestinationColorSpace& knownColorSpace() Template parameter could just be named accessor.
EWS
Comment 3 2021-05-24 14:25:20 PDT
Tools/Scripts/svn-apply failed to apply attachment 429492 [details] to trunk. Please resolve the conflicts and upload a new patch.
Sam Weinig
Comment 4 2021-05-24 19:53:36 PDT
Created attachment 429615 [details] Patch
EWS
Comment 5 2021-05-24 20:36:17 PDT
Committed r277994 (238107@main): <https://commits.webkit.org/238107@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429615 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-24 20:37:15 PDT
<rdar://problem/78433657>
Note You need to log in before you can comment on or make changes to this bug.