| Summary: | DestinationColorSpace's well known color space accessors cause unnecessary retain count churn | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2021-05-23 18:07:45 PDT
Created attachment 429492 [details]
Patch
Comment on attachment 429492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429492&action=review > Source/WebCore/platform/graphics/DestinationColorSpace.cpp:41 > +template<KnownColorSpaceAccessor knownColorSpaceAccessor> static const DestinationColorSpace& knownColorSpace() Template parameter could just be named accessor. Tools/Scripts/svn-apply failed to apply attachment 429492 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 429615 [details]
Patch
Committed r277994 (238107@main): <https://commits.webkit.org/238107@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429615 [details]. |