Bug 226122
| Summary: | [bmalloc] Rollout r276266 because WebKit processes are spending much more time in madvise | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> |
| Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Michael Saboff
The change for https://bugs.webkit.org/show_bug.cgi?id=224706 causes more calls to madvise. The way that the bmalloc scavenger calls madvise(..., MADV_FREE_REUSABLE) to decommit ranges is conservative, in that it merges free pages with adjacent free pages. When we decommit via madvise(), we decommit the whole free range, including pages that have already been decomitted. Rolling out r276266 to do some automated testing. At the same time, we'll work on changing the madvise() decommitting to be more precise.
Note that the committing of pages by calling madvise(..., MADV_FREE_REUSE), making them available for bmalloc to use, is precise. We only call it when are going to use the pages in the range.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Saboff
<rdar://78188389>
Michael Saboff
Committed r277898 (238032@main): <https://commits.webkit.org/238032@main>