Bug 226119

Summary: Stop using holdLock() in WebCore as it is not compatible with Clang thread safety analysis
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, achristensen, benjamin, calvaris, cgarcia, changseok, darin, ddkilzer, dino, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, ggaren, glenn, graouts, gustavo, gyuyoung.kim, hta, jer.noble, kangil.han, kkinnunen, kondapallykalyan, macpherson, menard, mmaxfield, philipj, pnormand, sam, sergio, tommyw, vjaquez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226116
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Chris Dumez
Reported 2021-05-21 16:09:30 PDT
Stop using holdLock() in WebCore as it is not compatible with Clang thread safety analysis.
Attachments
Patch (118.44 KB, patch)
2021-05-21 16:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (109.61 KB, patch)
2021-05-21 16:52 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (102.43 KB, patch)
2021-05-21 17:04 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (101.01 KB, patch)
2021-05-21 17:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (100.57 KB, patch)
2021-05-21 19:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-21 16:11:27 PDT
Created attachment 429357 [details] Patch
Chris Dumez
Comment 2 2021-05-21 16:52:18 PDT
Created attachment 429365 [details] Patch
Chris Dumez
Comment 3 2021-05-21 17:04:18 PDT
Created attachment 429367 [details] Patch
Chris Dumez
Comment 4 2021-05-21 17:08:12 PDT
Created attachment 429370 [details] Patch
Sam Weinig
Comment 5 2021-05-21 18:31:29 PDT
Comment on attachment 429370 [details] Patch Nice.
EWS
Comment 6 2021-05-21 18:54:21 PDT
Tools/Scripts/svn-apply failed to apply attachment 429370 [details] to trunk. Please resolve the conflicts and upload a new patch.
Chris Dumez
Comment 7 2021-05-21 19:07:54 PDT
Created attachment 429386 [details] Patch
EWS
Comment 8 2021-05-21 20:04:35 PDT
Committed r277908 (238041@main): <https://commits.webkit.org/238041@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429386 [details].
Radar WebKit Bug Importer
Comment 9 2021-05-21 20:05:18 PDT
<rdar://problem/78340445>
Note You need to log in before you can comment on or make changes to this bug.