Bug 226027

Summary:

The test of SmallSet.cpp should pass the right HashTrait to the HashSet it uses as a reference

Product:

WebKit

Reporter:

Robin Morisset <rmorisset>

Component:

Web Template Framework

Assignee:

Robin Morisset <rmorisset>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

amir_mark, mark.lam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

225848

Bug Blocks:

Attachments:

Description	Flags
Patch	mark.lam: review+, mark.lam: commit-queue-
Patch for landing	none

Description Robin Morisset 2021-05-20 10:29:40 PDT

SmallSet allows all values except for the max value.
So we test it on small values, including 0.

HashSet by default forbids 0, so it made the test crash.
We can trivially fix it by passing UnsignedWithZeroKeyHashTraits, which allows everything which is not max() or max()-1

Comment 1 Robin Morisset 2021-05-20 10:31:22 PDT

Created attachment 429185 [details]
Patch

Comment 2 Robin Morisset 2021-05-20 10:32:28 PDT

rdar://78217299

Comment 3 Robin Morisset 2021-05-20 10:35:07 PDT

*** Bug 225978 has been marked as a duplicate of this bug. ***

Comment 4 Mark Lam 2021-05-20 11:33:28 PDT

Comment on attachment 429185 [details]
Patch

r=me

Comment 5 Mark Lam 2021-05-20 11:34:58 PDT

(In reply to Robin Morisset from comment #0)
> SmallSet allows all values except for the max value.
> So we test it on small values, including 0.
> 
> HashSet by default forbids 0, so it made the test crash.
> We can trivially fix it by passing UnsignedWithZeroKeyHashTraits, which
> allows everything which is not max() or max()-1

You should put this explanation in the ChangeLog.

Comment 6 Robin Morisset 2021-05-20 12:09:51 PDT

Created attachment 429202 [details]
Patch for landing

Comment 7 EWS 2021-05-20 12:34:40 PDT

Committed r277817 (237964@main): <https://commits.webkit.org/237964@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429202 [details].