Bug 226026

Summary: Use CheckedLock more in WebCore
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, cmarcelo, darin, ddkilzer, eric.carlson, ews-watchlist, fred.wang, ggaren, glenn, hi, hta, jamesr, jer.noble, joepeck, jsbell, kkinnunen, luiz, mmaxfield, philipj, sam, sergio, tommyw, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2021-05-20 10:22:12 PDT
Use CheckedLock more in WebCore to benefit from Clang Thread Safety Analysis.
Comment 1 Chris Dumez 2021-05-20 10:24:32 PDT
Created attachment 429184 [details]
Patch
Comment 2 Geoffrey Garen 2021-05-20 11:23:02 PDT
Comment on attachment 429184 [details]
Patch

rs=me

Pretty cool!
Comment 3 EWS 2021-05-20 11:41:42 PDT
Committed r277805 (237960@main): <https://commits.webkit.org/237960@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429184 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-20 11:42:34 PDT
<rdar://problem/78269193>
Comment 5 Joseph Pecoraro 2021-05-20 12:24:07 PDT
Comment on attachment 429184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429184&action=review

> Source/WebCore/page/WheelEventTestMonitor.cpp:117
> +    Locker locker { m_lock };

Nice!