Bug 226026

Summary: Use CheckedLock more in WebCore
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, cmarcelo, darin, ddkilzer, eric.carlson, ews-watchlist, fred.wang, ggaren, glenn, hi, hta, jamesr, jer.noble, joepeck, jsbell, kkinnunen, luiz, mmaxfield, philipj, sam, sergio, tommyw, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-05-20 10:22:12 PDT
Use CheckedLock more in WebCore to benefit from Clang Thread Safety Analysis.
Attachments
Patch (113.52 KB, patch)
2021-05-20 10:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-20 10:24:32 PDT
Created attachment 429184 [details] Patch
Geoffrey Garen
Comment 2 2021-05-20 11:23:02 PDT
Comment on attachment 429184 [details] Patch rs=me Pretty cool!
EWS
Comment 3 2021-05-20 11:41:42 PDT
Committed r277805 (237960@main): <https://commits.webkit.org/237960@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429184 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-20 11:42:34 PDT
<rdar://problem/78269193>
Joseph Pecoraro
Comment 5 2021-05-20 12:24:07 PDT
Comment on attachment 429184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429184&action=review > Source/WebCore/page/WheelEventTestMonitor.cpp:117 > + Locker locker { m_lock }; Nice!
Note You need to log in before you can comment on or make changes to this bug.