Bug 226024

Summary: [webkitcorepy] Add shared terminal input code
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225985
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-05-20 09:14:28 PDT
Python 2 and 3 have slightly different stdin input functions, we should have shared code that centralizes these differences. In developing https://bugs.webkit.org/show_bug.cgi?id=225985, I found myself building a Yes/No command line input picker multiple times, that seems like something that should be shared as well.
Attachments
Patch (15.35 KB, patch)
2021-05-20 09:19 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (15.76 KB, patch)
2021-05-21 16:44 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (19.46 KB, patch)
2021-06-14 10:56 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (18.70 KB, patch)
2021-07-28 13:59 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (24.15 KB, patch)
2021-08-03 17:20 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.39 KB, patch)
2021-08-04 10:26 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-20 09:15:39 PDT
<rdar://problem/78261645>
Jonathan Bedard
Comment 2 2021-05-20 09:19:29 PDT
Created attachment 429178 [details] Patch
Jonathan Bedard
Comment 3 2021-05-21 16:44:23 PDT
Created attachment 429362 [details] Patch
Jonathan Bedard
Comment 4 2021-06-14 10:56:36 PDT
Created attachment 431344 [details] Patch
Jonathan Bedard
Comment 5 2021-07-28 13:59:37 PDT
Created attachment 434461 [details] Patch
Jonathan Bedard
Comment 6 2021-08-03 17:20:04 PDT
Created attachment 434873 [details] Patch
dewei_zhu
Comment 7 2021-08-04 10:02:58 PDT
Comment on attachment 434461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434461&action=review r=me > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:32 > + def choose(cls, prompt, options=None, default=None, strict=False, numbered=False): Is this used any where other than unit tests?
Jonathan Bedard
Comment 8 2021-08-04 10:03:58 PDT
(In reply to dewei_zhu from comment #7) > Comment on attachment 434461 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434461&action=review > > r=me > > > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:32 > > + def choose(cls, prompt, options=None, default=None, strict=False, numbered=False): > > Is this used any where other than unit tests? Not yet, but https://bugs.webkit.org/show_bug.cgi?id=225985 uses it. Patch for that change is up, needs some clean up before review, though.
Jonathan Bedard
Comment 9 2021-08-04 10:15:22 PDT
Comment on attachment 434461 [details] Patch Need to bump webkitcorepy version.
Jonathan Bedard
Comment 10 2021-08-04 10:26:23 PDT
Created attachment 434911 [details] Patch for landing
EWS
Comment 11 2021-08-04 10:58:59 PDT
Committed r280640 (240253@main): <https://commits.webkit.org/240253@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434911 [details].
Note You need to log in before you can comment on or make changes to this bug.