Summary: | Run webkitpy integration tests under pytest by default | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||||
Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=226230 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 224638 | ||||||||||
Attachments: |
|
Description
Sam Sneddon [:gsnedders]
2021-05-20 06:55:23 PDT
Created attachment 429166 [details]
Patch
Looks like webkitpy.tool.steps.haslanded_unittest.HasLandedTest.test_run is failing in Python 2 with this change. Created attachment 429183 [details]
Patch
Comment on attachment 429183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429183&action=review > Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py:40 > + # @unittest.skipUnless(subprocess.call('which interdiff', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE) == 0, "requires interdiff") Can we put a FIXME here with a bug so we don't forget that this is a problem? Created attachment 429676 [details]
Patch
Committed r278040 (238132@main): <https://commits.webkit.org/238132@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429676 [details]. |