Bug 226017

Summary: Run webkitpy integration tests under pytest by default
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226230
Bug Depends on:    
Bug Blocks: 224638    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-05-20 06:55:23 PDT
To do this, we need to make sure we have everything marked as xfail where appropriate.
Attachments
Patch (26.23 KB, patch)
2021-05-20 07:01 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Patch (26.25 KB, patch)
2021-05-20 10:06 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Patch (26.25 KB, patch)
2021-05-25 12:29 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-05-20 07:01:49 PDT
Created attachment 429166 [details] Patch
Jonathan Bedard
Comment 2 2021-05-20 07:25:05 PDT
Looks like webkitpy.tool.steps.haslanded_unittest.HasLandedTest.test_run is failing in Python 2 with this change.
Sam Sneddon [:gsnedders]
Comment 3 2021-05-20 10:06:24 PDT
Created attachment 429183 [details] Patch
Jonathan Bedard
Comment 4 2021-05-21 08:27:20 PDT
Comment on attachment 429183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429183&action=review > Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py:40 > + # @unittest.skipUnless(subprocess.call('which interdiff', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE) == 0, "requires interdiff") Can we put a FIXME here with a bug so we don't forget that this is a problem?
Sam Sneddon [:gsnedders]
Comment 5 2021-05-25 12:29:58 PDT
Created attachment 429676 [details] Patch
EWS
Comment 6 2021-05-25 13:28:05 PDT
Committed r278040 (238132@main): <https://commits.webkit.org/238132@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429676 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-25 13:29:24 PDT
<rdar://problem/78473261>
Note You need to log in before you can comment on or make changes to this bug.