Bug 225999

Summary: CRASH: Null-pointer deref in MediaSessionManagerCocoa::setNowPlayingInfo()
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226058
Bug Depends on: 225183    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2021-05-19 18:00:06 PDT
CRASH: Null-pointer deref in MediaSessionManagerCocoa::setNowPlayingInfo()
Attachments
Patch (1.97 KB, patch)
2021-05-19 18:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-05-19 18:00:32 PDT
<rdar://78232970>
Jer Noble
Comment 2 2021-05-19 18:02:14 PDT
Created attachment 429125 [details] Patch
Jean-Yves Avenard [:jya]
Comment 3 2021-05-20 02:25:02 PDT
Following https://bugs.webkit.org/show_bug.cgi?id=225183 ; nowPlayingInfo.artwork->imageData can never be null.
Jer Noble
Comment 4 2021-05-20 08:37:04 PDT
(In reply to Jean-Yves Avenard [:jya] from comment #3) > Following https://bugs.webkit.org/show_bug.cgi?id=225183 ; > nowPlayingInfo.artwork->imageData can never be null. Unfortunately, we're still seeing crashes even after that change landed. If imageData can truly never be null, it should be a Ref<> and not a RefPtr<>, which would enforce this at compile time.
EWS
Comment 5 2021-05-20 08:41:48 PDT
Committed r277784 (237945@main): <https://commits.webkit.org/237945@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429125 [details].
Note You need to log in before you can comment on or make changes to this bug.