Bug 225979

Summary: REGRESSION(r277505): Crash under WTF::Detail::CallableWrapper<WebKit::WebPageProxy::setUnderPageBackgroundColorOverride(WebCore::Color&&)::$_10, void>::call
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, hi, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Description Devin Rousso 2021-05-19 13:03:22 PDT 
.
Comment 1 Devin Rousso 2021-05-19 13:03:38 PDT 
<rdar://problem/78130098>
Comment 2 Devin Rousso 2021-05-19 13:09:19 PDT 
Created attachment 429089 [details]
Patch
Comment 3 Tim Horton 2021-05-20 14:12:59 PDT 
Comment on attachment 429089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429089&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1958
> +        if (m_pageClient)
> +            didChangeBackgroundColor();

Hmm, I would expect it here if you had moved the dereferencing of m_pageClient here, but inside didChangeBackgroundColor if you didn't. Why this version?
Comment 4 Devin Rousso 2021-05-20 14:16:35 PDT 
Comment on attachment 429089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429089&action=review

>> Source/WebKit/UIProcess/WebPageProxy.cpp:1958
>> +            didChangeBackgroundColor();
> 
> Hmm, I would expect it here if you had moved the dereferencing of m_pageClient here, but inside didChangeBackgroundColor if you didn't. Why this version?

No particular reason.  Just trying to keep the diff smaller I suppose.  I'll add `m_pageClient->didChangeBackgroundColor()` here instead.
Comment 5 Devin Rousso 2021-05-20 14:18:49 PDT 
Created attachment 429221 [details]
Patch
Comment 6 EWS 2021-05-20 14:54:00 PDT 
Committed r277827 (237973@main): <https://commits.webkit.org/237973@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429221 [details].