Bug 225922

Summary: [WPE] Spatial navigation tests fail with async overflow scrolling enabled
Product: WebKit Reporter: Chris Lord <clord>
Component: WebCore Misc.Assignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alex, apinheiro, cdumez, cfleizach, changseok, dino, dmazzoni, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, hi, jcraig, jdiggs, kangil.han, kondapallykalyan, mmaxfield, pdr, sabouhallawa, samuel_white, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226007    
Bug Blocks: 224596    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Lord 2021-05-18 09:42:11 PDT
These spatial navigation tests fail since enabling async overflow scrolling in tests in WPE:

fast/spatial-navigation/snav-clipped-overflowed-content.html
fast/spatial-navigation/snav-only-clipped-overflow-content.html
fast/spatial-navigation/snav-simple-content-overflow.html

Debugging with alexg, we discovered that this was because of clipping being disabled when async compositing is used at the RenderBox level. This leads us to believe that this issue may not be WPE-specific. Patch incoming.
Comment 1 Chris Lord 2021-05-18 09:54:33 PDT
Created attachment 428949 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-05-18 10:04:50 PDT
Comment on attachment 428949 [details]
Patch

I would prefer this happen in two stages: the first should just bet the clippedOverflowRect changes, and the second, smaller patch would fix spatial navigation.
Comment 3 Chris Lord 2021-05-20 11:12:40 PDT
Created attachment 429194 [details]
Patch
Comment 4 EWS 2021-05-20 17:24:41 PDT
Committed r277840 (237984@main): <https://commits.webkit.org/237984@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429194 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-20 17:25:22 PDT
<rdar://problem/78285532>