Bug 225876
| Summary: | UserGestureToken::processingUserGestureForMedia is use for non-media things | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | eric.carlson, jer.noble, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
The function UserGestureToken::processingUserGestureForMedia is use for non-media things such as the WebAuthenticatorCoordinator.
It really should be renamed to indicate what it does, since the current name is quite unclear.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
(or rather, we should either rename it or stop using it for non-media related things).
Sam Weinig
It looks like the differences between processingUserGesture() and processingUserGestureForMedia() are:
- processingUserGestureForMedia() works for any scope type, processingUserGesture() only works for All (not MediaOnly)
- processingUserGestureForMedia() works for state == ProcessingUserGesture or m_state == ProcessingPotentialUserGesture, processingUserGesture() only works for state == ProcessingUserGesture.
Sam Weinig
It took a while to find, but ProcessingPotentialUserGesture is set when a touch event is a potential tap and we are in TouchStart.
GestureScope::MediaOnly is used when propagating a user gesture on from a fetch or XHR.
Radar WebKit Bug Importer
<rdar://problem/78403759>