Bug 225873

Summary:

Drawing an sRGB image into a DisplayP3 canvas and then into sRGB canvas yields different results than if you only draw it into the sRGB canvas

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Canvas

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED MOVED

Severity:

Normal

CC:

dino, heycam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test case where both are drawn and tested	none
Test case where only the sRGB canvas is drawn into	none
Visual Test (all three squares should be the same color)	none
Visual Test (all three squares should be the same color)	none
Visual Test (only the sRGB ones)	none

Sam Weinig

Reported 2021-05-17 08:47:29 PDT

Drawing an sRGB image into a DisplayP3 canvas and then into sRGB canvas yields different results than if you only draw it into the sRGB canvas.

Attachments
Test case where both are drawn and tested (2.44 KB, text/html) 2021-05-17 08:48 PDT, Sam Weinig	no flags	Details
Test case where only the sRGB canvas is drawn into (2.45 KB, text/html) 2021-05-17 08:49 PDT, Sam Weinig	no flags	Details
Visual Test (all three squares should be the same color) (2.23 KB, text/html) 2021-05-17 09:06 PDT, Sam Weinig	no flags	Details
Visual Test (all three squares should be the same color) (2.16 KB, text/html) 2021-05-17 14:02 PDT, Sam Weinig	no flags	Details
Visual Test (only the sRGB ones) (2.16 KB, text/html) 2021-07-13 09:42 PDT, Sam Weinig	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2021-05-17 08:48:59 PDT

Created attachment 428832 [details] Test case where both are drawn and tested

Sam Weinig

Comment 2 2021-05-17 08:49:27 PDT

Created attachment 428833 [details] Test case where only the sRGB canvas is drawn into

Sam Weinig

Comment 3 2021-05-17 08:50:31 PDT

NOTE: This requires ToT WebKit with the CanvasColorSpacesEnabled feature enabled.

Sam Weinig

Comment 4 2021-05-17 08:52:29 PDT

This seems to be related to some cache, as to see the results, you must open a new window for each test case, otherwise, the tests will taint each other.

Sam Weinig

Comment 5 2021-05-17 08:55:14 PDT

It also seems to have to do with canvas accelerated graphics as disabling that (via the Debug -> Drawing and Compositing Flags, etc.) causes the issue to go away.

Sam Weinig

Comment 6 2021-05-17 09:06:26 PDT Comment hidden (obsolete)

Created attachment 428834 [details] Visual Test (all three squares should be the same color)

Sam Weinig

Comment 7 2021-05-17 14:02:08 PDT

Created attachment 428866 [details] Visual Test (all three squares should be the same color)

Sam Weinig

Comment 8 2021-05-17 14:03:01 PDT

Updated the visual test case, the getImageData() was not necessary. Now to uncover all the different image caches in WebKit to see which one is acting up.

Radar WebKit Bug Importer

Comment 9 2021-05-24 08:48:16 PDT

<rdar://problem/78402035>

Sam Weinig

Comment 10 2021-07-13 09:42:06 PDT

Created attachment 433411 [details] Visual Test (only the sRGB ones)

Cameron McCormack (:heycam)

Comment 11 2021-08-10 22:20:16 PDT

This is being tracked internally.

Sam Weinig

Comment 12 2021-08-11 10:11:50 PDT

👍

Note You need to log in before you can comment on or make changes to this bug.