[GLIB] Several offscreen canvas tests are failing since r277543

• Component: New Bugs
• Status: NEW ---

[Diego Pino]

The following tests are failing since r277543:

  imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.html [ Failure ]
  imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker.html [ Failure ]
  imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.html [ Failure ]
  imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs.worker.html [ Failure ]

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r277580%20%281802%29/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic-actual.txt
@@ -3,5 +3,5 @@
 Conic gradient function exists
 
 
-FAIL Conic gradient function exists ctx.createConicGradient is not a function. (In 'ctx.createConicGradient(0, 0, 25)', 'ctx.createConicGradient' is undefined)
+PASS Conic gradient function exists
 

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r277580%20%281802%29/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/the-offscreen-canvas/2d.getcontext.extraargs-actual.txt
@@ -3,5 +3,5 @@
 The 2D context ignores extra getContext arguments
 
 
-PASS The 2D context ignores extra getContext arguments
+FAIL The 2D context ignores extra getContext arguments Type error

imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.html can be resolved by updating its baseline (or emitting a new one for GLIB ports), although perhaps it's better to re-sync WPT tests.

[Chris Lord]

2d.gradient.conic has been replaced by 2d.gradient.conic.* upstream (which we've already synced) and I believe the extraargs tests are incorrect and don't match the DOM canvas equivalents - I've opened a PR for this upstream and will attach a patch here to sync once that lands: https://github.com/web-platform-tests/wpt/pull/29587

[Chris Lord]

Created attachment 433126 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Chris Lord]

Just waiting on upstream: https://github.com/web-platform-tests/wpt/pull/29587

[Chris Lord]

Comment on attachment 433126 [details]
Patch

Discussed this with Ms2ger, it appears that the spec intends that arguments are converted to objects first before being converted to dictionaries, so these failures aren't valid. Will open another bug about that.