Summary: | ASSERT(!toType.isArray()) failure in sh::CoerceSimple due to vector array dereference | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||||
Component: | ANGLE | Assignee: | Kyle Piddington <kpiddington> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | macOS 10.15 | ||||||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2021-05-17 03:36:05 PDT
Possibly the reason for <rdar://77968214> Created attachment 428818 [details]
Test to fix
Created attachment 428819 [details]
Test to fix
Created attachment 428897 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 428897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428897&action=review > Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/AddExplicitTypeCasts.cpp:44 > } You still need to Tools/Scripts/prepare-ChangeLog -b 225864 -g HEAD to get the ANGLE/ChangeLog edits > Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/AddExplicitTypeCasts.cpp:47 > + //1 element arrays need to be accounted for. It's really an issue with arrays of any arity? (got the crash/assert with other numbers, too). > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm:1274 > bool hasDepthSampler = false; Are these related to the array assert or are these in fact fixing some other bug? > LayoutTests/ChangeLog:10 > + WIP: adds just the tests. Might want to remove this line Created attachment 429086 [details]
Patch
Committed r277749 (237919@main): <https://commits.webkit.org/237919@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429086 [details]. |