Bug 225827

Summary: report-non-inclusive-language should skip node_modules directory
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, bdakin, darin, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213092    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2021-05-14 15:02:26 PDT
node_modules contain external code. Some of the modules might contain non-inclusive language. report-non-inclusive-language script should skip node_modules. e.g.: https://github.com/WebKit/WebKit/tree/main/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules https://github.com/WebKit/WebKit/tree/main/Websites/browserbench.org/Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules
Attachments
Patch (1.32 KB, patch)
2021-05-14 15:04 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-05-14 15:04:02 PDT
Created attachment 428667 [details] Patch
EWS
Comment 2 2021-05-15 04:00:54 PDT
Committed r277537 (237765@main): <https://commits.webkit.org/237765@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428667 [details].
Radar WebKit Bug Importer
Comment 3 2021-05-15 04:01:22 PDT
<rdar://problem/78054158>
Note You need to log in before you can comment on or make changes to this bug.