Bug 225816

Summary:

REGRESSION(r277313): [ Debug ] 2 TestWebKitAPI.IPCTestingAPI (API-Tests) are constant timeouts

Product:

WebKit

Reporter:

Robert Jenner <jenner>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, sam, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Robert Jenner 2021-05-14 10:48:36 PDT

The following two TestWebKitAPI.IPCTestingAPI are constant timeouts on Catalina, BigSur, and iOS14-Simulator Debug:

TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore
TestWebKitAPI.IPCTestingAPI.CanReceiveSharedMemory

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore&test=TestWebKitAPI.IPCTestingAPI.CanReceiveSharedMemory

Both APIs have the same history. It appears they both started timing out constantly at r277313. Working on reproduction steps.

Comment 1 Robert Jenner 2021-05-14 11:27:05 PDT

I have reproduced the timeout at BigSur Debug ToT using the following test:

run-api-tests TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore


I was also able to verify the regression point. The timeouts did occur at r277313, but did not occur at r277312. So it appears r277313 caused the regression.

Comment 2 Radar WebKit Bug Importer 2021-05-14 11:27:43 PDT

<rdar://problem/78025515>

Comment 3 Sam Weinig 2021-05-14 13:05:41 PDT

Ok, we just need to update the names of some messages from ImageData to PixelBuffer.

These tests are really error prone and will likely see more of this kind of failure if we don’t have a more robust way to catch these failures at compile time or at least better errors when the signatures don’t match at runtime.

Comment 4 Sam Weinig 2021-05-14 13:07:28 PDT

Created attachment 428648 [details]
Patch

Comment 5 EWS 2021-05-14 14:35:40 PDT

Committed r277506 (237737@main): <https://commits.webkit.org/237737@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428648 [details].