Bug 225796

Summary: REGRESSION(r277437):[ macOS ] inspector/unit-tests/heap-snapshot-collection-event.html is a constant text failure
Product: WebKit Reporter: Robert Jenner <jenner>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: inspector-bugzilla-changes, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Robert Jenner 2021-05-13 19:50:56 PDT
inspector/unit-tests/heap-snapshot-collection-event.html

is a constant text failure on macOS. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-enabled.html

TEXT DIFF:
 == Running test suite: HeapSnapshot.CollectionEvent
 -- Running test case: HeapSnapshot
 PASS: Should not have an error creating a snapshot.
-PASS: Should create HeapSnapshotProxy snapshot.
+Uncaught exception in Inspector page: SyntaxError: JSON Parse error: Single quotes (') are not allowed in JSON [HeapSnapshot.js:92:30]
 
--- Running test case: HeapSnapshotCollectionEvent
-PASS: Should not have an error creating a snapshot.
-PASS: Received HeapSnapshot.CollectionEvent.
-PASS: Collection should include at least 200 nodes (100 objects and 100 strings).
-PASS: Collection should affect the first snapshot.
 
--- Running test case: HeapSnapshot.prototype.update
-PASS: 0 Objects were dead before.
-PASS: At least 100 Objects are dead after.
-PASS: 0 strings were dead before.
-PASS: At least 100 strings are dead after.
-
Comment 1 Radar WebKit Bug Importer 2021-05-13 19:51:24 PDT
<rdar://problem/78000283>
Comment 2 Robert Jenner 2021-05-13 20:01:10 PDT
Ignore the history link above. I accidentally pasted the wrong on in. Here is the correct history link:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Funit-tests%2Fheap-snapshot-collection-event.html
Comment 3 Robert Jenner 2021-05-13 20:04:19 PDT
I have reproduced the failure at BigSur Production ToT using the following test:

run-webkit-tests inspector/unit-tests/heap-snapshot-collection-event.html --iterations 100 -f

It failed all 100 times when running that test. The history shows a clear regression point of r277437, and I was able to confirm it. The above test passes at r277436, but fails at r277437.
Comment 4 Alexey Proskuryakov 2021-05-19 14:59:08 PDT
Looks like this got fixed in https://trac.webkit.org/changeset/277480