| Summary: | m_calleeSaveRegisters should not be a pointer to a pointer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, nham, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Geoffrey Garen
2021-05-13 16:23:53 PDT
Created attachment 428573 [details]
Patch
Comment on attachment 428573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428573&action=review r=me with nits. > Source/JavaScriptCore/bytecode/CodeBlock.h:287 > + bool m_hasCalleeSaveRegisters { false }; Can't we just add an operator bool to RegisterAtOffsetList which is true when the FixedVector has a pointer? > > Source/JavaScriptCore/bytecode/CodeBlock.h:287
> > + bool m_hasCalleeSaveRegisters { false };
>
> Can't we just add an operator bool to RegisterAtOffsetList which is true
> when the FixedVector has a pointer?
If we did that, we wouldn't be able to distinguish "not initialized" from "initialized with 0 size". I'm not sure if that matters or not.
....so I took the conservative approach and maintained support for "initialized with 0 size". Comment on attachment 428573 [details]
Patch
CQ+
(In reply to Geoffrey Garen from comment #4) > ....so I took the conservative approach and maintained support for > "initialized with 0 size". Ah yes, all those platforms with 0 calleeSavedRegisters we support 🙃 Committed r277475 (237710@main): <https://commits.webkit.org/237710@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428573 [details]. |