Bug 225780

Summary: [Modern Media Controls] REGRESSION(r268308) AirPlay briefly disappears and then reappears when hovering over controls
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217536    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Devin Rousso 2021-05-13 13:50:02 PDT 
.
Comment 1 Devin Rousso 2021-05-13 13:53:42 PDT 
<rdar://problem/77984683>
Comment 2 Radar WebKit Bug Importer 2021-05-13 13:53:51 PDT 
<rdar://problem/77985060>
Comment 3 Devin Rousso 2021-05-13 13:58:55 PDT 
<rdar://problem/77984683>
Comment 4 Devin Rousso 2021-05-13 14:08:00 PDT 
Created attachment 428559 [details]
Patch
Comment 5 Devin Rousso 2021-05-13 14:35:53 PDT 
Created attachment 428562 [details]
Patch

disabling code that removes the `"webkitplaybacktargetavailabilitychanged"` in WebKit's builtin media controls could be a power regression
Comment 6 Devin Rousso 2021-05-13 14:37:02 PDT 
Comment on attachment 428562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428562&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:184
> +    if (m_ignoreNextMultipleRoutesDetectedDidChangeNotification)

oops I forgot to set it back to `false` 😅
Comment 7 Devin Rousso 2021-05-13 14:57:31 PDT 
Created attachment 428564 [details]
Patch
Comment 8 EWS 2021-05-13 21:44:21 PDT 
Committed r277481 (237716@main): <https://commits.webkit.org/237716@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428564 [details].