Bug 225726

Summary: [macOS] experimental "Use theme color for scroll area background" isn't working
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, hi, kondapallykalyan, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2021-05-12 18:05:19 PDT
.
Attachments
Patch (3.53 KB, patch)
2021-05-12 18:09 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2021-05-13 15:06 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-05-12 18:05:35 PDT
<rdar://problem/77933000>
Devin Rousso
Comment 2 2021-05-12 18:09:07 PDT
Created attachment 428442 [details] Patch
Tim Horton
Comment 3 2021-05-12 19:34:55 PDT
Comment on attachment 428442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428442&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:-3997 > - m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang); "CustomAppearance::ScrollingOverhang" can we get rid of this now?
Simon Fraser (smfr)
Comment 4 2021-05-12 20:38:05 PDT
Comment on attachment 428442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428442&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3889 > + if (page().settings().useThemeColorForScrollAreaBackgroundColor()) > + backgroundColor = page().themeColor(); > + if (page().settings().useSampledPageTopColorForScrollAreaBackgroundColor() && !backgroundColor.isValid()) > + backgroundColor = page().sampledPageTopColor(); > + if (!backgroundColor.isValid()) > + backgroundColor = m_rootExtendedBackgroundColor; Would be nicer to wrap this in a lambda that returns a Color. >> Source/WebCore/rendering/RenderLayerCompositor.cpp:-3997 >> - m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang); > > "CustomAppearance::ScrollingOverhang" can we get rid of this now? It seems no? The backgroundShouldExtendBeyondPage setting has a default value of false.
Tim Horton
Comment 5 2021-05-12 21:09:49 PDT
Comment on attachment 428442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428442&action=review >>> Source/WebCore/rendering/RenderLayerCompositor.cpp:-3997 >>> - m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang); >> >> "CustomAppearance::ScrollingOverhang" can we get rid of this now? > > It seems no? The backgroundShouldExtendBeyondPage setting has a default value of false. OH, I missed the code in updateLayerForOverhangAreasBackgroundColor that sets it, and thought this removed the setCustomAppearance() :D
Devin Rousso
Comment 6 2021-05-13 15:06:59 PDT
Created attachment 428567 [details] Patch
EWS
Comment 7 2021-05-13 16:11:14 PDT
Committed r277459 (237703@main): <https://commits.webkit.org/237703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428567 [details].
Note You need to log in before you can comment on or make changes to this bug.