Bug 225700

Summary: HTMLMediaElement::mediaLoadingFailedFatally() does direct dispatch of events; should schedule
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jean-yves.avenard, peng.liu6, philipj, rniwa, sergio, sojulibra
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225797
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Description Jer Noble 2021-05-12 09:02:24 PDT 
HTMLMediaElement::mediaLoadingFailedFatally() does direct dispatch of events; should schedule
Comment 1 Jer Noble 2021-05-12 09:03:05 PDT 
<rdar://75576322>
Comment 2 Jer Noble 2021-05-12 09:08:21 PDT 
Created attachment 428376 [details]
Patch
Comment 3 Jer Noble 2021-05-12 09:19:12 PDT 
Created attachment 428377 [details]
Patch
Comment 4 EWS 2021-05-12 11:00:31 PDT 
Committed r277379 (237635@main): <https://commits.webkit.org/237635@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428377 [details].
Comment 5 Darin Adler 2021-05-12 20:50:07 PDT 
Comment on attachment 428377 [details]
Patch

Seems like we could make this more foolproof if we set some kind of "event dispatch forbidden" or "JavaScript forbidden" state somewhere so we can spot mistakes like this instantly with test failures without more sophisticated testing.
Comment 6 Ryosuke Niwa 2021-05-12 22:02:07 PDT 
(In reply to Darin Adler from comment #5)
> Comment on attachment 428377 [details]
> Patch
> 
> Seems like we could make this more foolproof if we set some kind of "event
> dispatch forbidden" or "JavaScript forbidden" state somewhere so we can spot
> mistakes like this instantly with test failures without more sophisticated
> testing.

Yeah, we should probably do that in a separate bug since we want to keep this fix small enough to merge into a branch.
Comment 7 Darin Adler 2021-05-13 09:58:33 PDT 
(In reply to Ryosuke Niwa from comment #6)
> Yeah, we should probably do that in a separate bug since we want to keep
> this fix small enough to merge into a branch.

Of course! This bug is already fixed.