[GLIB] REGRESSION(r277225): imported/w3c/web-platform-tests/fetch/content-length/content-length.html is a flaky crash

• Component: New Bugs
• Status: RESOLVED FIXED

[Diego Pino]

The test started crashing in r277225:

https://results.webkit.org/?platform=GTK&platform=WPE&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fcontent-length%2Fcontent-length.html

Stacktrace:

https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r277315%20(1048)/imported/w3c/web-platform-tests/fetch/content-length/content-length-crash-log.txt

Program terminated with signal SIGSEGV, Segmentation fault.
#0  response_network_stream_read_data_cb (msg=<optimized out>, count=1) at ../libsoup/soup-client-message-io-http1.c:519
519	        if (client_io->base.read_state < SOUP_MESSAGE_IO_STATE_BODY_START)
[Current thread is 1 (Thread 0x7f790fd8bec0 (LWP 39283))]

Thread 1 (Thread 0x7f790fd8bec0 (LWP 39283)):
#0  response_network_stream_read_data_cb (msg=<optimized out>, count=1) at ../libsoup/soup-client-message-io-http1.c:519
#1  0x00007f791256b86c in g_cclosure_marshal_VOID__UINTv (closure=closure@entry=0x55bf822de690, return_value=return_value@entry=0x0, instance=instance@entry=0x55bf81ccbf30, args=args@entry=0x7ffde32b6ea0, marshal_data=marshal_data@entry=0x0, n_params=n_params@entry=1, param_types=0x55bf81cdf940) at ../gobject/gmarshal.c:704
#2  0x00007f7912569179 in _g_closure_invoke_va (closure=closure@entry=0x55bf822de690, return_value=return_value@entry=0x0, instance=instance@entry=0x55bf81ccbf30, args=args@entry=0x7ffde32b6ea0, n_params=1, param_types=0x55bf81cdf940) at ../gobject/gclosure.c:873
#3  0x00007f79125827df in g_signal_emit_valist (instance=0x55bf81ccbf30, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7ffde32b6ea0) at ../gobject/gsignal.c:3406
#4  0x00007f79125829c3 in g_signal_emit (instance=instance@entry=0x55bf81ccbf30, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553
#5  0x00007f7911147265 in soup_filter_input_stream_read_nonblocking (stream=<optimized out>, buffer=<optimized out>, count=1, error=0x7ffde32b6fb8) at ../libsoup/soup-filter-input-stream.c:165
#6  0x00007f7911145a5e in is_idle_connection_disconnected (conn=0x55bf81cae930 [SoupConnection]) at ../libsoup/soup-connection.c:961
#7  soup_connection_get_state (conn=0x55bf81cae930 [SoupConnection]) at ../libsoup/soup-connection.c:984
#8  0x00007f79111555e8 in connection_state_changed (object=0x55bf81cae930 [SoupConnection], param=<optimized out>, user_data=0x55bf81cc8150) at ../libsoup/soup-session.c:1534
#12 0x00007f79125829c3 in <emit signal notify:state on instance 0x55bf81cae930 [SoupConnection]> (instance=instance@entry=0x55bf81cae930, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3553
    #9  0x00007f7912568f3f in g_closure_invoke (closure=0x55bf81e275d0, return_value=return_value@entry=0x0, n_param_values=2, param_values=param_values@entry=0x7ffde32b71a0, invocation_hint=invocation_hint@entry=0x7ffde32b7120) at ../gobject/gclosure.c:810
    #10 0x00007f791257bd4b in signal_emit_unlocked_R (node=node@entry=0x55bf81c53660, detail=detail@entry=344, instance=instance@entry=0x55bf81cae930, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffde32b71a0) at ../gobject/gsignal.c:3741
    #11 0x00007f7912582861 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffde32b7340) at ../gobject/gsignal.c:3497
#13 0x00007f791256db54 in g_object_dispatch_properties_changed (object=0x55bf81cae930 [SoupConnection], n_pspecs=<optimized out>, pspecs=<optimized out>) at ../gobject/gobject.c:1206
#14 0x00007f791256d38e in g_object_notify_queue_thaw (object=0x55bf81cae930 [SoupConnection], nqueue=<optimized out>) at ../gobject/gobject.c:341
#15 0x00007f791256fd9b in g_object_thaw_notify (object=0x55bf81cae930 [SoupConnection]) at ../gobject/gobject.c:1443
#16 0x00007f7911144fc3 in soup_connection_set_state (conn=0x55bf81cae930 [SoupConnection], state=SOUP_CONNECTION_IDLE) at ../libsoup/soup-connection.c:1022
#17 0x00007f7911155385 in soup_session_unqueue_item (session=0x55bf81cc8150 [SoupSession], item=0x55bf82341b40) at ../libsoup/soup-session.c:1551
#18 0x00007f79111566b3 in soup_session_process_queue_item (loop=1, should_cleanup=0x7ffde32b75b4, item=0x55bf82341b40, session=0x55bf81cc8150 [SoupSession]) at ../libsoup/soup-session.c:1972
#19 async_run_queue (session=session@entry=0x55bf81cc8150 [SoupSession]) at ../libsoup/soup-session.c:2072
#20 0x00007f791115677d in queue_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at ../libsoup/soup-session.c:222
#21 0x00007f791246febb in g_main_dispatch (context=0x55bf81c6d180) at ../glib/gmain.c:3337
#22 g_main_context_dispatch (context=0x55bf81c6d180) at ../glib/gmain.c:4055
#23 0x00007f7912470168 in g_main_context_iterate (context=0x55bf81c6d180, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4131
#24 0x00007f7912470483 in g_main_loop_run (loop=0x55bf81c6e330) at ../glib/gmain.c:4329
#25 0x00007f79165c5d78 in WTF::RunLoop::run() () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:108
#26 0x00007f791a5dec3f in WebKit::AuxiliaryProcessMainBase<WebKit::NetworkProcess, false>::run(int, char**) (this=0x7ffde32b77c0, argc=3, argv=0x7ffde32b7968) at ../../Source/WebKit/Shared/AuxiliaryProcessMain.h:70
#27 0x00007f791a5dbb90 in WebKit::AuxiliaryProcessMain<WebKit::NetworkProcessMainSoup>(int, char**) (argc=3, argv=0x7ffde32b7968) at ../../Source/WebKit/Shared/AuxiliaryProcessMain.h:96
#28 0x00007f791a5cb7dd in WebKit::NetworkProcessMain(int, char**) (argc=3, argv=0x7ffde32b7968) at ../../Source/WebKit/NetworkProcess/soup/NetworkProcessMainSoup.cpp:61
#29 0x000055bf817a4959 in main(int, char**) (argc=3, argv=0x7ffde32b7968) at ../../Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:31

[Diego Pino]

It seems to be an error in libsoup. Attempt to fix it: https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/220

[Diego Pino]

This other test is also failing with the same stracktrace:

imported/w3c/web-platform-tests/cors/preflight-failure.htm

https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r277341%20(1059)/imported/w3c/web-platform-tests/cors/preflight-failure-crash-log.txt

[Diego Pino]

Another test failing with the same stacktrace:

imported/w3c/web-platform-tests/eventsource/eventsource-close.htm

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r277619%20(1816)/imported/w3c/web-platform-tests/eventsource/eventsource-close-crash-log.txt

[Diego Pino]

Gardened in r277632.

imported/w3c/web-platform-tests/eventsource/eventsource-close.htm started to crash in r277601.

[Radar WebKit Bug Importer]

<rdar://problem/78141533>

[Carlos Alberto Lopez Perez]

This two tests stopped crashing around r277946 (updating to libsoup3)