Bug 225605

Summary: Add null check in CachedResource::clearLoader
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, ggaren, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2021-05-10 12:25:10 PDT
Add null check in CachedResource::clearLoader
Attachments
Patch (1.57 KB, patch)
2021-05-10 12:26 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-05-10 12:26:03 PDT
Created attachment 428193 [details] Patch
Alex Christensen
Comment 2 2021-05-10 12:26:06 PDT
<rdar://problem/69912354>
Geoffrey Garen
Comment 3 2021-05-10 12:46:59 PDT
Comment on attachment 428193 [details] Patch r=me You can make this fewer lines of code if you keep it as ASSERT(m_loader).
Alex Christensen
Comment 4 2021-05-10 12:49:33 PDT
Comment on attachment 428193 [details] Patch I agree. I have received the feedback many times in the past that the WebKit developers don't like having code that looks like this: ASSERT(something); if (something) somethingIsTrue(); But for some reason they are ok with this. Maybe we should have another super-long style discussion on webkit-dev.
EWS
Comment 5 2021-05-10 14:17:18 PDT
Committed r277292 (237553@main): <https://commits.webkit.org/237553@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428193 [details].
Note You need to log in before you can comment on or make changes to this bug.